refactor(ble): minor BLE library cleanup #11789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Kolcha wants to merge 1 commit into espressif:master

from Kolcha:ble-cleanup

Open

refactor(ble): minor BLE library cleanup #11789

Kolcha wants to merge 1 commit into espressif:master from Kolcha:ble-cleanup

+73 −84

Conversation

Kolcha

Copy link

Contributor

@Kolcha Kolcha commented Sep 3, 2025

Checklist

Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md")
Please provide related links (eg. Issue which will be closed by this Pull Request)
Please update relevant Documentation if applicable
Please check Contributing guide
Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.

Description of Change

minor BLE library cleanup:

made many getters const (as it supposed to be)
pass string by reference in modified classes
other random code cleanup / fixes

Test Scenarios

I have tested my Pull Request on Arduino-esp32 core v3.3.0 with ESP32. Successful build is enough to confirm that everything is ok.

Related links

nothing

@Kolcha Kolcha requested review from lucasssvaz and SuGlider as code owners

September 3, 2025 10:06

@github-actions GitHub Actions

Copy link

Contributor

github-actions bot commented Sep 3, 2025 •

edited

Loading

Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello Kolcha, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9946a98

@github-actions GitHub Actions

Copy link

Contributor

github-actions bot commented Sep 3, 2025 •

edited

Loading

Test Results

76 files 76 suites 13m 10s ⏱️
38 tests 38 ✅ 0 💤 0 ❌
241 runs 241 ✅ 0 💤 0 ❌

Results for commit 9946a98.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev assigned lucasssvaz

Sep 3, 2025

@github-actions GitHub Actions

Copy link

Contributor

github-actions bot commented Sep 3, 2025 •

edited

Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32C5	💚 -38	⚠️ +2	0.00	0.00	0	0	0.00	0.00
ESP32S3	💚 -12	⚠️ +24	0.00	0.00	0	0	0.00	0.00
ESP32C3	💚 -38	⚠️ +2	💚 -0.01	0.00	0	0	0.00	0.00
ESP32C6	💚 -38	⚠️ +2	💚 -0.01	0.00	0	0	0.00	0.00
ESP32H2	💚 -38	⚠️ +2	💚 -0.01	0.00	0	0	0.00	0.00
ESP32	💚 -16	⚠️ +28	0.00	0.00	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32C5		ESP32S3		ESP32C3		ESP32C6		ESP32H2		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
libraries/BLE/examples/Beacon_Scanner	💚 -38	0	💚 -12	0	💚 -38	0	💚 -38	0	💚 -38	0	💚 -16	0
libraries/BLE/examples/Client	⚠️ +2	0	⚠️ +24	0	⚠️ +2	0	⚠️ +2	0	⚠️ +2	0	⚠️ +24	0
libraries/BLE/examples/Client_secure_static_passkey	⚠️ +2	0	⚠️ +24	0	⚠️ +2	0	⚠️ +2	0	⚠️ +2	0	⚠️ +24	0
libraries/BLE/examples/EddystoneTLM_Beacon	⚠️ +2	0	⚠️ +24	0	⚠️ +2	0	⚠️ +2	0	⚠️ +2	0	⚠️ +24	0
libraries/BLE/examples/EddystoneURL_Beacon	⚠️ +2	0	⚠️ +24	0	⚠️ +2	0	⚠️ +2	0	⚠️ +2	0	⚠️ +24	0
libraries/BLE/examples/Notify	⚠️ +2	0	⚠️ +24	0	⚠️ +2	0	⚠️ +2	0	⚠️ +2	0	⚠️ +24	0
libraries/BLE/examples/Scan	⚠️ +2	0	⚠️ +24	0	⚠️ +2	0	⚠️ +2	0	⚠️ +2	0	⚠️ +24	0
libraries/BLE/examples/Server	⚠️ +2	0	⚠️ +24	0	⚠️ +2	0	⚠️ +2	0	⚠️ +2	0	⚠️ +28	0
libraries/BLE/examples/Server_multiconnect	⚠️ +2	0	⚠️ +24	0	⚠️ +2	0	⚠️ +2	0	⚠️ +2	0	⚠️ +24	0
libraries/BLE/examples/Server_secure_static_passkey	⚠️ +2	0	⚠️ +24	0	⚠️ +2	0	⚠️ +2	0	⚠️ +2	0	⚠️ +24	0
libraries/BLE/examples/UART	⚠️ +2	0	⚠️ +24	0	⚠️ +2	0	⚠️ +2	0	⚠️ +2	0	⚠️ +24	0
libraries/BLE/examples/Write	⚠️ +2	0	⚠️ +24	0	⚠️ +2	0	⚠️ +2	0	⚠️ +2	0	⚠️ +24	0
libraries/BLE/examples/iBeacon	⚠️ +2	0	⚠️ +24	0	⚠️ +2	0	⚠️ +2	0	⚠️ +2	0	⚠️ +24	0

@lucasssvaz

Copy link

Member

lucasssvaz commented Sep 4, 2025

Could you rebase your PR with the latest BLE changes ?

@Kolcha


 refactor(ble): minor BLE library cleanup

9946a98

- made many getters `const` (as it supposed to be)
- pass string by reference in modified classes
- other random code cleanup / fixes

@Kolcha Kolcha force-pushed the ble-cleanup branch from c710949 to 9946a98 Compare

September 4, 2025 18:20

Labels

None yet

2 participants

@Kolcha @lucasssvaz

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(ble): minor BLE library cleanup #11789

Are you sure you want to change the base?

refactor(ble): minor BLE library cleanup #11789

Conversation

@Kolcha Kolcha commented Sep 3, 2025

Checklist

Description of Change

Test Scenarios

Related links

Uh oh!

github-actions bot commented Sep 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Sep 3, 2025 •

edited

Loading

Uh oh!

Test Results

Uh oh!

github-actions bot commented Sep 3, 2025 •

edited

Loading

Uh oh!

Memory usage test (comparing PR against master branch)

Uh oh!

lucasssvaz commented Sep 4, 2025

Uh oh!

Uh oh!

refactor(ble): minor BLE library cleanup #11789

Are you sure you want to change the base?

refactor(ble): minor BLE library cleanup #11789

Conversation

@Kolcha Kolcha commented Sep 3, 2025

Checklist

Description of Change

Test Scenarios

Related links

Uh oh!

github-actions bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Memory usage test (comparing PR against master branch)

Uh oh!

lucasssvaz commented Sep 4, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 3, 2025 •

edited

Loading

github-actions bot commented Sep 3, 2025 •

edited

Loading

github-actions bot commented Sep 3, 2025 •

edited

Loading