Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat(usb): allow the MIDI constructor to define a device name #11720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
me-no-dev merged 31 commits into master from feature/device_name_usb_midi
Sep 10, 2025

Conversation

Copy link
Collaborator

@SuGlider SuGlider commented Aug 12, 2025 •
edited
Loading

Description of Change

This PR will allow the user to modify the MIDI USB Device Name (device descriptor). Fomer API continues to be valid and the default device name is "TinyUSB MIDI".

The user can change the device name by passing a string to the constructor, declaring it like this `USBMIDI myMIDI("MyDeviceName");

Setting the MIDI device name follow an order:

  1. Name set via constructor (if any, not NULL or "")
  2. Name set via SET_USB_MIDI_DEVICE_NAME() macro (if defined, not NULL and "")
  3. Default name "TinyUSB MIDI"

Tests scenarios

ESP32-S3 | ESP32-S2 using USB OTG mode with UART for Serial:
USB CDC On Boot: "Disabled"
Upload Mode: "UART0 / Hardware CDC"
USB Mode: "USB OTG (TinyUSB)"

2 USB Cables, one for UART and the other for USB, connected to the USB Host (PC).

For testing please go to https://hardwaretester.com/midi
Allow the browser to select the MIDI device for the name and MIDI commands

#include "USB.h"
#include "USBMIDI.h"
USBMIDI MIDI("ESP32 MIDI New Device"); // replaces TinyUSB MIDI name
#define END_OF_SONG 255
uint8_t notes[] = { END_OF_SONG, 71, 76, 79, 78, 76, 83, 81, 78, 76, 79, 78, 75, 77, 71 };
uint8_t noteIndex = 0; // From 0 to sizeof(notes)
#define SONG_LENGTH (sizeof(notes) - 1) // END_OF_SONG does not attribute to the length.
void setup() {
 Serial.begin(115200); // UART output
 MIDI.begin();
 USB.begin();
}
void loop() {
 // Stop current note
 MIDI.noteOff(notes[noteIndex]);
 // Play next note
 noteIndex = noteIndex < SONG_LENGTH ? noteIndex + 1 : 0;
 if (notes[noteIndex] != END_OF_SONG) {
 MIDI.noteOn(notes[noteIndex], 64);
 }
 delay(250); // each note will play for 250ms
}

Related links

closes #11714 

This PR will allow the user to modify the MIDI USB Device Name (device descriptor). Fomer API continues to be valid and the default device name is "TinyUSB MIDI". 
The user can change the device name by passing a string to the constructor, declaring it like this `USBMIDI myMIDI("MyDeviceName");
@SuGlider SuGlider moved this from Todo to In Progress in Arduino ESP32 Core Project Roadmap Aug 12, 2025
@SuGlider SuGlider marked this pull request as draft August 12, 2025 14:29
Copy link
Contributor

github-actions bot commented Aug 12, 2025 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "feat(usb): allow the MIDI constructor to define a device name":
    • body's lines must not be longer than 100 characters

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello SuGlider, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4bca706

Copy link
Member

Github is having some issues. CI should pass after it normalizes.

image
SuGlider reacted with thumbs up emoji

Copy link
Contributor

github-actions bot commented Aug 12, 2025 •
edited
Loading

Test Results

76 files 76 suites 13m 11s ⏱️
38 tests 38 ✅ 0 💤 0 ❌
241 runs 241 ✅ 0 💤 0 ❌

Results for commit 4bca706.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 22, 2025 •
edited
Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32P40⚠️ +4080.00⚠️ +0.11000.000.00
ESP32S30⚠️ +2320.00⚠️ +0.06000.000.00
ESP32S20⚠️ +2320.00⚠️ +0.07000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/ArduinoOTA/examples/BasicOTA000000000000--00
libraries/AsyncUDP/examples/AsyncUDPClient000000000000--00
libraries/AsyncUDP/examples/AsyncUDPMulticastServer000000000000--00
libraries/AsyncUDP/examples/AsyncUDPServer000000000000--00
libraries/BLE/examples/Beacon_Scanner00--00--00000000
libraries/BLE/examples/Client00--00--00000000
libraries/BLE/examples/Client_secure_static_passkey00--00--00000000
libraries/BLE/examples/EddystoneTLM_Beacon00--00--00000000
libraries/BLE/examples/EddystoneURL_Beacon00--00--00000000
libraries/BLE/examples/Notify00--00--00000000
libraries/BLE/examples/Scan00--00--00000000
libraries/BLE/examples/Server00--00--00000000
libraries/BLE/examples/Server_multiconnect00--00--00000000
libraries/BLE/examples/Server_secure_static_passkey00--00--00000000
libraries/BLE/examples/UART00--00--00000000
libraries/BLE/examples/Write00--00--00000000
libraries/BLE/examples/iBeacon00--00--00000000
libraries/DNSServer/examples/CaptivePortal000000000000--00
libraries/EEPROM/examples/eeprom_class0000000000000000
libraries/EEPROM/examples/eeprom_extra0000000000000000
libraries/EEPROM/examples/eeprom_write0000000000000000
libraries/ESP32/examples/AnalogOut/LEDCFade0000000000000000
libraries/ESP32/examples/AnalogOut/LEDCGammaFade0000------0000--
libraries/ESP32/examples/AnalogOut/LEDCSingleChannel0000000000000000
libraries/ESP32/examples/AnalogOut/LEDCSoftwareFade0000000000000000
libraries/ESP32/examples/AnalogOut/SigmaDelta0000000000000000
libraries/ESP32/examples/AnalogOut/ledcFrequency0000000000000000
libraries/ESP32/examples/AnalogOut/ledcWrite_RGB0000000000000000
libraries/ESP32/examples/AnalogRead0000000000000000
libraries/ESP32/examples/AnalogReadContinuous0000000000000000
libraries/ESP32/examples/ArduinoStackSize0000000000000000
libraries/ESP32/examples/CI/CIBoardsTest0000000000000000
libraries/ESP32/examples/ChipID/GetChipID0000000000000000
libraries/ESP32/examples/DeepSleep/TimerWakeUp000000000000--00
libraries/ESP32/examples/FreeRTOS/BasicMultiThreading0000000000000000
libraries/ESP32/examples/FreeRTOS/Mutex0000000000000000
libraries/ESP32/examples/FreeRTOS/Queue0000000000000000
libraries/ESP32/examples/FreeRTOS/Semaphore0000000000000000
libraries/ESP32/examples/GPIO/BlinkRGB0000000000000000
libraries/ESP32/examples/GPIO/FunctionalInterrupt0000000000000000
libraries/ESP32/examples/GPIO/FunctionalInterruptLambda0000000000000000
libraries/ESP32/examples/GPIO/FunctionalInterruptStruct0000000000000000
libraries/ESP32/examples/GPIO/GPIOInterrupt0000000000000000
libraries/ESP32/examples/HWCDC_Events000000--000000--
libraries/ESP32/examples/MacAddress/GetMacAddress0000000000000000
libraries/ESP32/examples/RMT/Legacy_RMT_Driver_Compatible0000000000000000
libraries/ESP32/examples/RMT/RMTCallback0000000000000000
libraries/ESP32/examples/RMT/RMTLoopback0000000000000000
libraries/ESP32/examples/RMT/RMTReadXJT0000000000000000
libraries/ESP32/examples/RMT/RMTWrite_RGB_LED0000000000000000
libraries/ESP32/examples/RMT/RMT_CPUFreq_Test0000000000000000
libraries/ESP32/examples/RMT/RMT_EndOfTransmissionState0000000000000000
libraries/ESP32/examples/RMT/RMT_LED_Blink0000000000000000
libraries/ESP32/examples/ResetReason/ResetReason0000000000000000
libraries/ESP32/examples/ResetReason/ResetReason20000000000000000
libraries/ESP32/examples/Serial/BaudRateDetect_Demo0000000000000000
libraries/ESP32/examples/Serial/OnReceiveError_BREAK_Demo0000000000000000
libraries/ESP32/examples/Serial/OnReceive_Demo0000000000000000
libraries/ESP32/examples/Serial/RS485_Echo_Demo0000000000000000
libraries/ESP32/examples/Serial/RxFIFOFull_Demo0000000000000000
libraries/ESP32/examples/Serial/RxTimeout_Demo0000000000000000
libraries/ESP32/examples/Serial/Serial_All_CPU_Freqs0000000000000000
libraries/ESP32/examples/Serial/Serial_STD_Func_OnReceive0000000000000000
libraries/ESP32/examples/Serial/onReceiveExample0000000000000000
libraries/ESP32/examples/Template/ExampleTemplate0000000000000000
libraries/ESP32/examples/Time/SimpleTime000000000000--00
libraries/ESP32/examples/Timer/RepeatTimer0000000000000000
libraries/ESP32/examples/Timer/WatchdogTimer0000000000000000
libraries/ESP_I2S/examples/ES8388_loopback0000000000000000
libraries/ESP_I2S/examples/Simple_tone0000000000000000
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Master00--00000000--00
libraries/ESP_NOW/examples/ESP_NOW_Broadcast_Slave00--00000000--00
libraries/ESP_NOW/examples/ESP_NOW_Network00--00000000--00
libraries/ESP_NOW/examples/ESP_NOW_Serial00--00000000--00
libraries/ESPmDNS/examples/mDNS-SD_Extended000000000000--00
libraries/ESPmDNS/examples/mDNS_Web_Server000000000000--00
libraries/Ethernet/examples/ETH_W5500_Arduino_SPI0000000000000000
libraries/Ethernet/examples/ETH_W5500_IDF_SPI0000000000000000
libraries/Ethernet/examples/ETH_WIFI_BRIDGE000000000000--00
libraries/FFat/examples/FFat_Test0000000000000000
libraries/FFat/examples/FFat_time000000000000--00
libraries/HTTPClient/examples/Authorization000000000000--00
libraries/HTTPClient/examples/BasicHttpClient000000000000--00
libraries/HTTPClient/examples/BasicHttpsClient000000000000--00
libraries/HTTPClient/examples/HTTPClientEnterprise00--00000000--00
libraries/HTTPClient/examples/ReuseConnection000000000000--00
libraries/HTTPClient/examples/StreamHttpClient000000000000--00
libraries/HTTPUpdate/examples/httpUpdate000000000000--00
libraries/HTTPUpdate/examples/httpUpdateSPIFFS000000000000--00
libraries/HTTPUpdate/examples/httpUpdateSecure000000000000--00
libraries/HTTPUpdateServer/examples/WebUpdater000000000000--00
libraries/Hash/examples/HEX0000000000000000
libraries/Hash/examples/MD50000000000000000
libraries/Hash/examples/PBKDF2_HMAC0000000000000000
libraries/Hash/examples/SHA10000000000000000
libraries/Hash/examples/SHA20000000000000000
libraries/Hash/examples/SHA30000000000000000
libraries/Hash/examples/SHA3Stream0000000000000000
libraries/Insights/examples/DiagnosticsSmokeTest00--00000000--00
libraries/Insights/examples/MinimalDiagnostics00--00000000--00
libraries/LittleFS/examples/LITTLEFS_test0000000000000000
libraries/LittleFS/examples/LITTLEFS_time000000000000--00
libraries/Matter/examples/MatterColorLight00--000000000000
libraries/Matter/examples/MatterCommissionTest00--000000000000
libraries/Matter/examples/MatterComposedLights00--000000000000
libraries/Matter/examples/MatterContactSensor00--000000000000
libraries/Matter/examples/MatterDimmableLight00--000000000000
libraries/Matter/examples/MatterEnhancedColorLight00--000000000000
libraries/Matter/examples/MatterEvents00--000000000000
libraries/Matter/examples/MatterFan00--000000000000
libraries/Matter/examples/MatterHumiditySensor00--000000000000
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs00--000000000000
libraries/Matter/examples/MatterMinimum00--000000000000
libraries/Matter/examples/MatterOccupancySensor00--000000000000
libraries/Matter/examples/MatterOnIdentify00--000000000000
libraries/Matter/examples/MatterOnOffLight00--000000000000
libraries/Matter/examples/MatterOnOffPlugin00--000000000000
libraries/Matter/examples/MatterPressureSensor00--000000000000
libraries/Matter/examples/MatterSmartButon00--000000000000
libraries/Matter/examples/MatterTemperatureLight00--000000000000
libraries/Matter/examples/MatterTemperatureSensor00--000000000000
libraries/Matter/examples/MatterThermostat00--000000000000
libraries/NetBIOS/examples/ESP_NBNST000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientInsecure000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientPSK000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientSecure000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientSecureEnterprise00--00000000--00
libraries/NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientShowPeerCredentials000000000000--00
libraries/NetworkClientSecure/examples/WiFiClientTrustOnFirstUse000000000000--00
libraries/OpenThread/examples/CLI/COAP/coap_lamp00--------0000--
libraries/OpenThread/examples/CLI/COAP/coap_switch00--------0000--
libraries/OpenThread/examples/CLI/SimpleCLI00--------0000--
libraries/OpenThread/examples/CLI/SimpleNode00--------0000--
libraries/OpenThread/examples/CLI/SimpleThreadNetwork/ExtendedRouterNode00--------0000--
libraries/OpenThread/examples/CLI/SimpleThreadNetwork/LeaderNode00--------0000--
libraries/OpenThread/examples/CLI/SimpleThreadNetwork/RouterNode00--------0000--
libraries/OpenThread/examples/CLI/ThreadScan00--------0000--
libraries/OpenThread/examples/CLI/onReceive00--------0000--
libraries/OpenThread/examples/Native/SimpleThreadNetwork/LeaderNode00--------0000--
libraries/OpenThread/examples/Native/SimpleThreadNetwork/RouterNode00--------0000--
libraries/PPP/examples/PPP_Basic0000000000000000
libraries/PPP/examples/PPP_WIFI_BRIDGE000000000000--00
libraries/Preferences/examples/Prefs2Struct0000000000000000
libraries/Preferences/examples/StartCounter0000000000000000
libraries/RainMaker/examples/RMakerCustom00--00000000----
libraries/RainMaker/examples/RMakerCustomAirCooler00--00000000----
libraries/RainMaker/examples/RMakerSonoffDualR300--00000000----
libraries/RainMaker/examples/RMakerSwitch00--00000000----
libraries/SD/examples/SD_Test0000000000000000
libraries/SD/examples/SD_time000000000000--00
libraries/SPI/examples/SPI_Multiple_Buses0000000000000000
libraries/SPIFFS/examples/SPIFFS_Test0000000000000000
libraries/SPIFFS/examples/SPIFFS_time000000000000--00
libraries/TFLiteMicro/examples/hello_world0000000000000000
libraries/Ticker/examples/Blinker0000000000000000
libraries/Ticker/examples/TickerBasic0000000000000000
libraries/Ticker/examples/TickerParameter0000000000000000
libraries/Update/examples/AWS_S3_OTA_Update000000000000--00
libraries/Update/examples/HTTPS_OTA_Update000000000000--00
libraries/Update/examples/HTTP_Client_AES_OTA_Update000000000000--00
libraries/Update/examples/HTTP_Server_AES_OTA_Update000000000000--00
libraries/Update/examples/OTAWebUpdater000000000000--00
libraries/Update/examples/SD_Update0000000000000000
libraries/WebServer/examples/AdvancedWebServer000000000000--00
libraries/WebServer/examples/FSBrowser000000000000--00
libraries/WebServer/examples/Filters000000000000--00
libraries/WebServer/examples/HelloServer000000000000--00
libraries/WebServer/examples/HttpAdvancedAuth000000000000--00
libraries/WebServer/examples/HttpAuthCallback000000000000--00
libraries/WebServer/examples/HttpAuthCallbackInline000000000000--00
libraries/WebServer/examples/HttpBasicAuth000000000000--00
libraries/WebServer/examples/HttpBasicAuthSHA1000000000000--00
libraries/WebServer/examples/HttpBasicAuthSHA1orBearerToken000000000000--00
libraries/WebServer/examples/Middleware00--00000000--00
libraries/WebServer/examples/MultiHomedServers000000000000--00
libraries/WebServer/examples/PathArgServer000000000000--00
libraries/WebServer/examples/SDWebServer000000000000--00
libraries/WebServer/examples/SimpleAuthentification000000000000--00
libraries/WebServer/examples/UploadHugeFile000000000000--00
libraries/WebServer/examples/WebServer000000000000--00
libraries/WebServer/examples/WebUpdate000000000000--00
libraries/WiFi/examples/FTM/FTM_Initiator000000000000--00
libraries/WiFi/examples/FTM/FTM_Responder000000000000--00
libraries/WiFi/examples/SimpleWiFiServer000000000000--00
libraries/WiFi/examples/WPS00--00000000--00
libraries/WiFi/examples/WiFiAccessPoint000000000000--00
libraries/WiFi/examples/WiFiBlueToothSwitch00--00--0000--00
libraries/WiFi/examples/WiFiClient000000000000--00
libraries/WiFi/examples/WiFiClientBasic000000000000--00
libraries/WiFi/examples/WiFiClientConnect000000000000--00
libraries/WiFi/examples/WiFiClientEnterprise00--00000000--00
libraries/WiFi/examples/WiFiClientEvents000000000000--00
libraries/WiFi/examples/WiFiClientStaticIP000000000000--00
libraries/WiFi/examples/WiFiExtender000000000000--00
libraries/WiFi/examples/WiFiIPv6000000000000--00
libraries/WiFi/examples/WiFiMulti000000000000--00
libraries/WiFi/examples/WiFiMultiAdvanced000000000000--00
libraries/WiFi/examples/WiFiScan000000000000--00
libraries/WiFi/examples/WiFiScanAsync000000000000--00
libraries/WiFi/examples/WiFiScanDualAntenna000000000000--00
libraries/WiFi/examples/WiFiScanTime000000000000--00
libraries/WiFi/examples/WiFiSmartConfig00--00000000--00
libraries/WiFi/examples/WiFiTelnetToSerial000000000000--00
libraries/WiFi/examples/WiFiUDPClient000000000000--00
libraries/WiFiProv/examples/WiFiProv00--00000000--00
libraries/Wire/examples/WireMaster0000000000000000
libraries/Wire/examples/WireScan0000000000000000
libraries/Wire/examples/WireSlave0000000000000000
libraries/Wire/examples/WireSlaveFunctionalCallback0000000000000000
libraries/Zigbee/examples/Zigbee_Analog_Input_Output00--000000000000
libraries/Zigbee/examples/Zigbee_Binary_Input_Output00--------0000--
libraries/Zigbee/examples/Zigbee_CarbonDioxide_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Color_Dimmable_Light00--------0000--
libraries/Zigbee/examples/Zigbee_Color_Dimmer_Switch00--000000000000
libraries/Zigbee/examples/Zigbee_Contact_Switch00--------0000--
libraries/Zigbee/examples/Zigbee_Dimmable_Light00--------0000--
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor00--000000000000
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor_MultiPhase00--000000000000
libraries/Zigbee/examples/Zigbee_Electrical_DC_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Fan_Control00--000000000000
libraries/Zigbee/examples/Zigbee_Gateway00--000000----00
libraries/Zigbee/examples/Zigbee_Illuminance_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Multistate_Input_Output00--000000000000
libraries/Zigbee/examples/Zigbee_OTA_Client00--------0000--
libraries/Zigbee/examples/Zigbee_Occupancy_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_On_Off_Light00--------0000--
libraries/Zigbee/examples/Zigbee_On_Off_MultiSwitch00--000000000000
libraries/Zigbee/examples/Zigbee_On_Off_Switch00--000000000000
libraries/Zigbee/examples/Zigbee_PM25_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Power_Outlet00--000000000000
libraries/Zigbee/examples/Zigbee_Pressure_Flow_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Range_Extender00--000000000000
libraries/Zigbee/examples/Zigbee_Scan_Networks00--------0000--
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy00--------0000--
libraries/Zigbee/examples/Zigbee_Temperature_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Thermostat00--000000000000
libraries/Zigbee/examples/Zigbee_Vibration_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Wind_Speed_Sensor00--------0000--
libraries/Zigbee/examples/Zigbee_Window_Covering00--------0000--
libraries/ESP32/examples/DeepSleep/TouchWakeUp--000000------00
libraries/ESP32/examples/TWAI/TWAIreceive--00000000000000
libraries/ESP32/examples/TWAI/TWAItransmit--00000000000000
libraries/ESP32/examples/Touch/TouchButton--000000------00
libraries/ESP32/examples/Touch/TouchInterrupt--000000------00
libraries/ESP32/examples/Touch/TouchRead--000000------00
libraries/ESP_I2S/examples/Record_to_WAV--0000--------00
libraries/ESP_SR/examples/Basic--0000----------
libraries/Ethernet/examples/ETH_TLK110--00----------00
libraries/SD_MMC/examples/SD2USBMSC--0000----------
libraries/SD_MMC/examples/SDMMC_Test--0000--------00
libraries/SD_MMC/examples/SDMMC_time--0000--------00
libraries/USB/examples/CompositeDevice--⚠️ +20⚠️ +720⚠️ +720--------
libraries/USB/examples/ConsumerControl--00⚠️ +720⚠️ +720--------
libraries/USB/examples/CustomHIDDevice--⚠️ +20⚠️ +720⚠️ +720--------
libraries/USB/examples/FirmwareMSC--000000--------
libraries/USB/examples/Gamepad--⚠️ +20⚠️ +720⚠️ +720--------
libraries/USB/examples/HIDVendor--⚠️ +20⚠️ +720⚠️ +720--------
libraries/USB/examples/Keyboard/KeyboardLogout--00⚠️ +720⚠️ +720--------
libraries/USB/examples/Keyboard/KeyboardMessage--00⚠️ +720⚠️ +720--------
libraries/USB/examples/Keyboard/KeyboardReprogram--00⚠️ +720⚠️ +720--------
libraries/USB/examples/Keyboard/KeyboardSerial--⚠️ +20⚠️ +720⚠️ +720--------
libraries/USB/examples/KeyboardAndMouseControl--⚠️ +20⚠️ +720⚠️ +720--------
libraries/USB/examples/MIDI/MidiController--⚠️ +4080⚠️ +2320⚠️ +2320--------
libraries/USB/examples/MIDI/MidiInterface--⚠️ +3580⚠️ +2240⚠️ +2240--------
libraries/USB/examples/MIDI/MidiMusicBox--⚠️ +3380⚠️ +2040⚠️ +2040--------
libraries/USB/examples/MIDI/ReceiveMidi--⚠️ +3400⚠️ +2040⚠️ +2040--------
libraries/USB/examples/Mouse/ButtonMouseControl--00⚠️ +720⚠️ +720--------
libraries/USB/examples/SystemControl--00⚠️ +720⚠️ +720--------
libraries/USB/examples/USBMSC--000000--------
libraries/USB/examples/USBSerial--000000--------
libraries/USB/examples/USBVendor--⚠️ +20⚠️ +720⚠️ +720--------
libraries/ESP32/examples/Camera/CameraWebServer----0000------00
ESP32/examples/Camera/CameraWebServer (2)----0000------00
ESP32/examples/Camera/CameraWebServer (3)----00----------
libraries/ESP32/examples/DeepSleep/ExternalWakeUp----0000------00
libraries/BluetoothSerial/examples/DiscoverConnect--------------00
libraries/BluetoothSerial/examples/GetLocalMAC--------------00
libraries/BluetoothSerial/examples/SerialToSerialBT--------------00
libraries/BluetoothSerial/examples/SerialToSerialBTM--------------00
libraries/BluetoothSerial/examples/SerialToSerialBT_Legacy--------------00
libraries/BluetoothSerial/examples/SerialToSerialBT_SSP--------------00
libraries/BluetoothSerial/examples/bt_classic_device_discovery--------------00
libraries/BluetoothSerial/examples/bt_remove_paired_devices--------------00
libraries/ESP32/examples/DeepSleep/SmoothBlink_ULP_Code--------------00
libraries/Ethernet/examples/ETH_LAN8720--------------00
libraries/SimpleBLE/examples/SimpleBleDevice--------------00

@SuGlider SuGlider moved this from In Progress to In Review in Arduino ESP32 Core Project Roadmap Sep 9, 2025
@SuGlider SuGlider marked this pull request as ready for review September 9, 2025 14:00
@SuGlider SuGlider requested a review from a team as a code owner September 9, 2025 14:00
Copilot

This comment was marked as outdated.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the ability to define a custom USB MIDI device name through multiple methods while maintaining backward compatibility. The default device name remains "TinyUSB MIDI" but can now be overridden via constructor parameter or compile-time macro.

Key changes:

  • Adds a new USBMIDI constructor that accepts a device name parameter
  • Implements a priority system for device naming (constructor > macro > default)
  • Adds a compile-time macro SET_USB_MIDI_DEVICE_NAME() for setting device names

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
libraries/USB/src/USBMIDI.h Adds new constructor, destructor, and device name management methods
libraries/USB/src/USBMIDI.cpp Implements device name logic with memory management and priority handling
libraries/USB/examples/MIDI/MidiInterface/MidiInterface.ino Demonstrates macro-based device naming
libraries/USB/examples/MIDI/MidiController/MidiController.ino Demonstrates constructor-based device naming
cores/esp32/Arduino.h Defines the SET_USB_MIDI_DEVICE_NAME macro and default name constant

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

SuGlider and others added 2 commits September 9, 2025 11:15 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Sep 9, 2025
@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Sep 10, 2025
@me-no-dev me-no-dev merged commit 6952595 into master Sep 10, 2025
79 checks passed
@me-no-dev me-no-dev deleted the feature/device_name_usb_midi branch September 10, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@me-no-dev me-no-dev me-no-dev approved these changes

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@lucasssvaz lucasssvaz Awaiting requested review from lucasssvaz

Labels
Area: Peripherals API Relates to peripheral's APIs. Status: Pending Merge Pull Request is ready to be merged
Projects
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Allow USB Midi descriptor to be changed

AltStyle によって変換されたページ (->オリジナル) /