-
Notifications
You must be signed in to change notification settings - Fork 7.7k
fix(python): Fixes for Python code scanning alerts #11668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Test Results
76 files 76 suites 13m 11s ⏱️
38 tests 38 ✅ 0 💤 0 ❌
241 runs 241 ✅ 0 💤 0 ❌
Results for commit 03d0566.
♻️ This comment has been updated with latest results.
e20d87c
to
38aed79
Compare
3dc348f
to
e08c9e7
Compare
b717988
to
5d5e23b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it seems contaminated with Hash changes from #11676
I think that it seems contaminated with Hash changes from #11676
As it is written in the description it requires the hashing changes. It will be rebased once they are merged. You can still review the python codes as it wont change
77e9dd5
to
cf576d6
Compare
1a198e8
to
ffaca1b
Compare
683e3ca
to
be5d99c
Compare
@P-R-O-C-H-Y @SuGlider PTAL
Uh oh!
There was an error while loading. Please reload this page.
Description of Change
This pull request fixes issues reported by CodeQL. Mostly files which are not closed if an exception occurs.
Requires #11676
Tested locally.