fix(component): Use external diag logs to avoid error #11661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

me-no-dev merged 1 commit into master from fix/idf-component-logs

Jul 28, 2025

Merged

fix(component): Use external diag logs to avoid error #11661

me-no-dev merged 1 commit into master from fix/idf-component-logs

Jul 28, 2025

Conversation

P-R-O-C-H-Y

Copy link

Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Jul 28, 2025

Description of Change

This pull request introduces a configuration change to enable external log wrapping for diagnostics across multiple example projects. The change is consistent across the affected files and aims to standardize diagnostic logging.

Configuration updates for diagnostics:

Added CONFIG_DIAG_USE_EXTERNAL_LOG_WRAP=y to enable external log wrapping for diagnostics in the following example projects:
- idf_component_examples/esp_matter_light/sdkconfig.defaults
- idf_component_examples/hello_world/sdkconfig.defaults
- idf_component_examples/hw_cdc_hello_world/sdkconfig.defaults

Tests scenarios

Tested using Hello_world example, when Wi-Fi is included the compilation was broken before this fix.

Related links

Closes #11634

@P-R-O-C-H-Y


 fix(component): Use external diag logs to avoid error

311955c

@P-R-O-C-H-Y P-R-O-C-H-Y requested review from me-no-dev and lucasssvaz

July 28, 2025 10:00

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this

Jul 28, 2025

@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from SuGlider as a code owner

July 28, 2025 10:00

@P-R-O-C-H-Y P-R-O-C-H-Y added Area: Arduino as ESP-IDF component Status: Review needed labels

Jul 28, 2025

@github-actions GitHub Actions

Copy link

Contributor

github-actions bot commented Jul 28, 2025

Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 311955c