Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Update HTTPUpdateServer.h to Fix SPIFFS Update error: Bad Size Given #11586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kapyaar wants to merge 1 commit into espressif:master
base: master
Choose a base branch
Loading
from kapyaar:master

Conversation

Copy link

@kapyaar kapyaar commented Jul 11, 2025

if (!Update.begin(SPIFFS.totalBytes(), U_SPIFFS)) {

throws an error "Update error: Bad Size Given". Changing to

if (!Update.begin(UPDATE_SIZE_UNKNOWN, U_SPIFFS)) {

fixes #9967. Submitting a PR as per #9967 (comment) 

 if (!Update.begin(SPIFFS.totalBytes(), U_SPIFFS)) { 
throws an error "Update error: Bad Size Given". Changing to 
if (!Update.begin(UPDATE_SIZE_UNKNOWN, U_SPIFFS)) {
fixes espressif#9967
@kapyaar kapyaar requested a review from a team as a code owner July 11, 2025 17:01
Copy link

CLAassistant commented Jul 11, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update HTTPUpdateServer.h":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello kapyaar, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against d3afef7

Copy link
Collaborator

Jason2866 commented Jul 13, 2025 •
edited
Loading

@me-no-dev is it planned to replace the dead horse spiffs with LittleFS in HTTPUpdateServer?

Copy link
Member

Actually here the size of the FS partition should be read and used. Code can be abstracted to flash any FS type, instead of just SPIFFS

Copy link
Author

kapyaar commented Jul 14, 2025

If there is a better approach to handle this, Please update or let me know, I can do another PR. One way or the other, It would be great to get this fixed, as at this point, with each release (for backward compatibility), a manual update of this file is the only way out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpupdateserver filesystem update "Update error: Bad Size Given" for 8MB version of ESP32

AltStyle によって変換されたページ (->オリジナル) /