feat(hosted): Add method to update the hosted slave firmware #11580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

me-no-dev wants to merge 1 commit into master

from feature/hosted_ota_and_version

Draft

feat(hosted): Add method to update the hosted slave firmware #11580

me-no-dev wants to merge 1 commit into master from feature/hosted_ota_and_version

+19 −5

Conversation

me-no-dev

Copy link

Member

@me-no-dev me-no-dev commented Jul 10, 2025

This pull request introduces updates to the WiFiGeneric module, focusing on enhancing functionality for ESP-HOSTED configurations and improving code maintainability. The most significant changes include adding a new method for updating slave firmware, modifying the inclusion of headers, and adjusting commented-out code for clarity.

Enhancements to ESP-HOSTED functionality:

Added a new method WiFiGenericClass::updateSlave in WiFiGeneric.cpp and declared it in WiFiGeneric.h. This method facilitates OTA updates for the slave firmware using the esp_hosted_slave_ota function. [1] [2]

Code organization and cleanup:

Adjusted the inclusion of headers in WiFiGeneric.cpp by uncommenting #include "esp_hosted.h" and commenting out unused headers and declarations, such as esp_hosted_transport_config.h and related functions.
Added comments in the wifiHostedInit function to explain potential heap exceptions when retrieving the firmware version of older slave firmware.
Removed an unused extern "C" block after the #include directives for better code clarity.

@me-no-dev


 feat(hosted): Add method to update the hosted slave firmware

c2368cc

@github-actions GitHub Actions

Copy link

Contributor

github-actions bot commented Jul 10, 2025

Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against c2368cc

@github-actions GitHub Actions

Copy link

Contributor

github-actions bot commented Jul 10, 2025 •

edited

Loading

Test Results

76 files 76 suites 13m 8s ⏱️
38 tests 38 ✅ 0 💤 0 ❌
241 runs 241 ✅ 0 💤 0 ❌

Results for commit c2368cc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions

Copy link

Contributor

github-actions bot commented Jul 10, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32P4	0	0	0.00	0.00	0	0	0.00	0.00
ESP32S3	0	0	0.00	0.00	0	0	0.00	0.00
ESP32S2	0	0	0.00	0.00	0	0	0.00	0.00
ESP32C3	0	0	0.00	0.00	0	0	0.00	0.00
ESP32C6	0	0	0.00	0.00	0	0	0.00	0.00
ESP32	0	0	0.00	0.00	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32P4		ESP32S3		ESP32S2		ESP32C3		ESP32C6		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
libraries/WiFi/examples/FTM/FTM_Initiator	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/FTM/FTM_Responder	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/SimpleWiFiServer	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiAccessPoint	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiClient	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiClientBasic	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiClientConnect	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiClientEvents	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiClientStaticIP	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiExtender	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiIPv6	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiMulti	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiMultiAdvanced	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiScan	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiScanAsync	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiScanDualAntenna	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiScanTime	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiTelnetToSerial	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiUDPClient	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WPS	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiBlueToothSwitch	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiClientEnterprise	-	-	-	-	-	-	-	-	-	-	-	-
libraries/WiFi/examples/WiFiSmartConfig	-	-	-	-	-	-	-	-	-	-	-	-

@me-no-dev me-no-dev added the Status: Blocked upstream 🛑 label

Jul 11, 2025

Labels

Status: Blocked upstream 🛑

1 participant

@me-no-dev

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(hosted): Add method to update the hosted slave firmware #11580

Are you sure you want to change the base?

feat(hosted): Add method to update the hosted slave firmware #11580

Conversation

@me-no-dev me-no-dev commented Jul 10, 2025

Enhancements to ESP-HOSTED functionality:

Code organization and cleanup:

Uh oh!

github-actions bot commented Jul 10, 2025

Uh oh!

github-actions bot commented Jul 10, 2025 •

edited

Loading

Uh oh!

Test Results

Uh oh!

github-actions bot commented Jul 10, 2025

Memory usage test (comparing PR against master branch)

Uh oh!

Uh oh!

feat(hosted): Add method to update the hosted slave firmware #11580

Are you sure you want to change the base?

feat(hosted): Add method to update the hosted slave firmware #11580

Conversation

@me-no-dev me-no-dev commented Jul 10, 2025

Enhancements to ESP-HOSTED functionality:

Code organization and cleanup:

Uh oh!

github-actions bot commented Jul 10, 2025

Uh oh!

github-actions bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Jul 10, 2025

Memory usage test (comparing PR against master branch)

Uh oh!

Uh oh!

github-actions bot commented Jul 10, 2025 •

edited

Loading