Search code, repositories, users, issues, pull requests...

feat(zigbee): Update ESP-ZIGBEE-SDK to 1.6.6 #11641


 feat(zigbee): Add Binary Output support

b4beb16

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this

Jul 7, 2025

@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from lucasssvaz as a code owner

July 7, 2025 09:21

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Blocked upstream 🛑 Area: Zigbee labels

Jul 7, 2025

@github-actions GitHub Actions

Copy link

Contributor

github-actions bot commented Jul 7, 2025 •

edited

Loading

Messages
📖	🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 7d37b7d

@github-actions GitHub Actions

Copy link

Contributor

github-actions bot commented Jul 7, 2025 •

edited

Loading

Test Results

76 files 76 suites 13m 11s ⏱️
38 tests 38 ✅ 0 💤 0 ❌
241 runs 241 ✅ 0 💤 0 ❌

Results for commit 7d37b7d.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev marked this pull request as draft

July 9, 2025 10:25

@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request

Jul 25, 2025

Merged

P-R-O-C-H-Y added 2 commits

August 21, 2025 19:39


 Merge branch 'master' into feaz/zigbee-binary-output


 Merge branch 'master' into feaz/zigbee-binary-output

e11776c

@github-actions GitHub Actions

Copy link

Contributor

github-actions bot commented Sep 4, 2025 •

edited

Loading

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32C5	0	0	0.00	0.00	0	0	0.00	0.00
ESP32S3	0	⚠️ +196	0.00	⚠️ +0.03	0	0	0.00	0.00
ESP32S2	0	⚠️ +196	0.00	⚠️ +0.03	0	0	0.00	0.00
ESP32C3	0	0	0.00	0.00	0	0	0.00	0.00
ESP32C6	0	0	0.00	0.00	0	0	0.00	0.00
ESP32H2	0	0	0.00	0.00	0	0	0.00	0.00
ESP32	0	⚠️ +196	0.00	⚠️ +0.03	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32C5		ESP32S3		ESP32S2		ESP32C3		ESP32C6		ESP32H2		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
libraries/Zigbee/examples/Zigbee_Analog_Input_Output	0	0	⚠️ +196	0	⚠️ +196	0	0	0	0	0	0	0	⚠️ +196	0
libraries/Zigbee/examples/Zigbee_Binary_Input_Output	-	-	-	-	-	-	-	-	-	-	-	-	-	-
libraries/Zigbee/examples/Zigbee_CarbonDioxide_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Color_Dimmable_Light	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Color_Dimmer_Switch	0	0	⚠️ +196	0	⚠️ +196	0	0	0	0	0	0	0	⚠️ +196	0
libraries/Zigbee/examples/Zigbee_Contact_Switch	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Dimmable_Light	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor	0	0	⚠️ +196	0	⚠️ +196	0	0	0	0	0	0	0	⚠️ +196	0
libraries/Zigbee/examples/Zigbee_Electrical_AC_Sensor_MultiPhase	0	0	⚠️ +196	0	⚠️ +196	0	0	0	0	0	0	0	⚠️ +196	0
libraries/Zigbee/examples/Zigbee_Electrical_DC_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Fan_Control	0	0	⚠️ +196	0	⚠️ +196	0	0	0	0	0	0	0	⚠️ +196	0
libraries/Zigbee/examples/Zigbee_Gateway	0	0	⚠️ +196	0	⚠️ +196	0	0	0	-	-	-	-	⚠️ +196	0
libraries/Zigbee/examples/Zigbee_Illuminance_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_OTA_Client	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Occupancy_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_On_Off_Light	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_On_Off_MultiSwitch	0	0	⚠️ +196	0	⚠️ +196	0	0	0	0	0	0	0	⚠️ +196	0
libraries/Zigbee/examples/Zigbee_On_Off_Switch	0	0	⚠️ +196	0	⚠️ +196	0	0	0	0	0	0	0	⚠️ +196	0
libraries/Zigbee/examples/Zigbee_PM25_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Power_Outlet	0	0	⚠️ +196	0	⚠️ +196	0	0	0	0	0	0	0	⚠️ +196	0
libraries/Zigbee/examples/Zigbee_Pressure_Flow_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Range_Extender	0	0	⚠️ +196	0	⚠️ +196	0	0	0	0	0	0	0	⚠️ +196	0
libraries/Zigbee/examples/Zigbee_Scan_Networks	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Temperature_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Thermostat	0	0	⚠️ +196	0	⚠️ +196	0	0	0	0	0	0	0	⚠️ +196	0
libraries/Zigbee/examples/Zigbee_Vibration_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-
libraries/Zigbee/examples/Zigbee_Wind_Speed_Sensor	0	0	-	-	-	-	-	-	0	0	0	0	-	-


 docs(zigbee): Update docs with Binary Output

f2aa056

@P-R-O-C-H-Y P-R-O-C-H-Y marked this pull request as ready for review

September 4, 2025 13:52

@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from pedrominatel as a code owner

September 4, 2025 13:52

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Review needed and removed Status: Blocked upstream 🛑 labels

@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from me-no-dev

September 4, 2025 13:53

@P-R-O-C-H-Y P-R-O-C-H-Y added this to Arduino ESP32 Core Project Roadmap

@github-project-automation github-project-automation bot moved this to Todo in Arduino ESP32 Core Project Roadmap

@P-R-O-C-H-Y P-R-O-C-H-Y moved this from Todo to In Review in Arduino ESP32 Core Project Roadmap

me-no-dev

me-no-dev approved these changes

@me-no-dev me-no-dev requested a review from Copilot

September 4, 2025 14:55

lucasssvaz

lucasssvaz approved these changes

Copilot

Copilot AI reviewed

Copy link

Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds binary output functionality to the existing Zigbee binary input implementation, enabling bidirectional control of binary devices. The enhancement allows creation of custom switches without requiring binding, complementing the existing binary input sensor capabilities.

Key Changes

Implementation of binary output cluster support alongside existing binary input functionality
Addition of callback mechanism for handling binary output state changes
Updated example demonstrating both input and output capabilities with multiple endpoint configurations

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
libraries/Zigbee/src/ep/ZigbeeBinary.h	Adds binary output constants, method declarations, and private members for output functionality
libraries/Zigbee/src/ep/ZigbeeBinary.cpp	Implements complete binary output functionality including cluster creation, attribute handling, and state management
libraries/Zigbee/examples/Zigbee_Binary_Input_Output/Zigbee_Binary_Input_Output.ino	Updates example to demonstrate both input and output capabilities with callback functions
libraries/Zigbee/examples/Zigbee_Binary_Input_Output/README.md	Updates documentation to reflect new binary input/output capabilities
docs/en/zigbee/ep_binary.rst	Comprehensive documentation update covering binary output API and usage examples

Comments suppressed due to low confidence (1)

libraries/Zigbee/src/ep/ZigbeeBinary.cpp:1

[nitpick] The method name binaryOutputChanged is misleading as it suggests the method is called when the output has already changed, but it's actually the method that triggers the callback. Consider renaming to triggerBinaryOutputCallback or notifyBinaryOutputChange to better reflect its purpose.

// Copyright 2025 Espressif Systems (Shanghai) PTE LTD

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

libraries/Zigbee/src/ep/ZigbeeBinary.h Outdated Show resolved Hide resolved

libraries/Zigbee/examples/Zigbee_Binary_Input_Output/Zigbee_Binary_Input_Output.ino Outdated Show resolved Hide resolved


 fix(zigbee): Remove duplicate and update formatting

8fbf1f9

pedrominatel

pedrominatel approved these changes

@me-no-dev me-no-dev added Status: Pending Merge and removed Status: Review needed labels

@pre-commit-ci-lite


 ci(pre-commit): Apply automatic fixes

034533c

@github-actions github-actions bot added the Status: Pre-commit fixes required ⚠️ label


 fix(example): Fix spelling error

7d37b7d

@github-actions github-actions bot removed the Status: Pre-commit fixes required ⚠️ label

@me-no-dev me-no-dev merged commit c3f9513 into master

55 checks passed

@github-project-automation github-project-automation bot moved this from In Review to Done in Arduino ESP32 Core Project Roadmap