-
Notifications
You must be signed in to change notification settings - Fork 7.7k
ci(idf): Use included IDF examples in CI #11240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
e111001
to
53d8c55
Compare
Test Results
76 files 76 suites 12m 46s ⏱️
38 tests 38 ✅ 0 💤 0 ❌
241 runs 241 ✅ 0 💤 0 ❌
Results for commit 128bc3f.
♻️ This comment has been updated with latest results.
c994244
to
d67a19b
Compare
3e4f23e
to
d9a0e9c
Compare
@lucasssvaz - what is the reason for removing matter_light specific target default sdkconfig? Those are examples.
@lucasssvaz - what is the reason for removing matter_light specific target default sdkconfig? Those are examples.
We already talked about it - question answered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SuGlider Is it planned to adopt the example to work with actual Arduino Core 3.2.0?
Currently it is only for Arduino Core ~3.0.5
@SuGlider Is it planned to adopt the example to work with actual Arduino Core 3.2.0? Currently it is only for Arduino Core ~3.0.5
@Jason2866 - Could you please share your findings about this issue? Thanks!
@SuGlider Is it planned to adopt the example to work with actual Arduino Core 3.2.0? Currently it is only for Arduino Core ~3.0.5
I guess this is about https://github.com/espressif/arduino-esp32/blob/master/idf_component_examples/esp_matter_light/main/idf_component.yml
dependencies:
espressif/esp_matter:
version: "^1.3.0"
# Adds Arduino Core from GitHub repository using main branch
espressif/arduino-esp32:
version: "^3.0.5"
override_path: "../../../"
pre_release: true
# testing - using Arduino from the repository
# version: "master" # branch or commit
# git: https://github.com/espressif/arduino-esp32.git
That shall be solved with the changes:
dependencies:
espressif/esp_matter:
version: ">=1.3.0"
# Adds Arduino Core from GitHub repository using main branch
espressif/arduino-esp32:
version: ">=3.0.5"
override_path: "../../../"
pre_release: true
@SuGlider Try to compile. Compile errors come up when trying with Core 3.2.0 and IDF 5.4.1+
@SuGlider Try to compile. Compile errors come up when trying with Core 3.2.0 and IDF 5.4.1+
I have done it. I was able to build the Matter application for the ESP32 using Core 3.2.0, IDF5.4.1 and Matter 1.4.0.
I have checkout this PR, installed IDF v5.4 and imported the Arduino as Component Matter Light project from the repository.
I have modified the main/idf_component.yml
file to comment out the last 2 lines (override_path: "../../../"
and pre_release: true
). I have run idf.py set-target esp32
and then idf.py build
. All good.
@SuGlider Dont get it going with branch master and IDF 5.4.1+ from 25.04.11
https://github.com/pioarduino/platform-espressif32/actions/runs/14667529394/job/41165941836
used example https://github.com/pioarduino/platform-espressif32/tree/refs/heads/test_matter/examples/espidf-arduino-matter-light
@SuGlider Dont get it going with branch master and IDF 5.4.1+ from 25.04.11 https://github.com/pioarduino/platform-espressif32/actions/runs/14667529394/job/41165941836 used example https://github.com/pioarduino/platform-espressif32/tree/refs/heads/test_matter/examples/espidf-arduino-matter-light
This error is related std::to_underlying
it needs C++ 23.
I have changed the CMakeLists.txt file in this PR to use C++ 2a.
d8e7a91
Try that change within pioarduino and let me know.
@Jason2866 - please evaluate pioarduino/platform-espressif32#146
@SuGlider Will do. Needs a pio python script to change the used c++ version.
Just noticed we need to fix the Arduino Lib Builder pioarduino script.
There is this entry
CXXFLAGS=[
"-march=rv32imc_zicsr_zifencei",
"-std=gnu++2b",
"-fexceptions",
"-fno-rtti",
"-fuse-cxa-atexit",
"-std=gnu++2a"
],
I guess it fetches the different settings from normal run and the Matter run. Similar issue than adding the ndebug entry.
I can't override correctly when two set here.
This weird setup does work:
build_unflags =
-std=c++17
-std=gnu++2b
build_flags =
-std=gnu++2a
This weird setup does work:
build_unflags = -std=c++17 -std=gnu++2b build_flags = -std=gnu++2a
does this setup build it for pioarduino?
I have tried 2b but it fails with Matter 1.4
2a is the best ESP Matter can go.
Yes, this setup does build successfully. It uses Matter v1.4. and ++2a
https://github.com/pioarduino/platform-espressif32/actions/runs/14669953811/job/41173950292
Thx for your help!
Uh oh!
There was an error while loading. Please reload this page.
Description of Change
Add compilation test of our existing ESP-IDF examples to CI
Tests scenarios
CI