-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Adds setToneChannel() implementation #10305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds the implementation to setToneChannel() declared in Arduino.h, but removed when movin from Arduino 2.x to 3.x.
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results
56 files - 83 56 suites - 83 4m 54s ⏱️ - 1h 37m 54s
21 tests - 9 21 ✅ - 9 0 💤 ±0 0 ❌ ±0
135 runs - 168 135 ✅ - 168 0 💤 ±0 0 ❌ ±0
Results for commit d10ea95. ± Comparison against base commit e70f4d3.
This pull request removes 9 tests.
performance.coremark.test_coremark ‐ test_coremark
performance.fibonacci.test_fibonacci ‐ test_fibonacci
performance.psramspeed.test_psramspeed ‐ test_psramspeed
performance.ramspeed.test_ramspeed ‐ test_ramspeed
performance.superpi.test_superpi ‐ test_superpi
test_touch_errors
test_touch_interrtupt
test_touch_read
validation.periman.test_periman ‐ test_periman
♻️ This comment has been updated with latest results.
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uh oh!
There was an error while loading. Please reload this page.
Description of Change
Implements setToneChannel() declared in Arduino.h, but removed when moving from Arduino 2.x to 3.x.
Fixes a Task priority problem in the code. Previous priority was the same of the Arduino Task and it prevents the Tone Queue to be processed before Tone commands are executed.
Tests scenarios
Tested using ESP32-S3, checking the logs.
Log:
Related links
Closes #10297