-
Notifications
You must be signed in to change notification settings - Fork 13.3k
add Stream::readStringUntil function that uses string terminator #9011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It is not a breaking change and does not override the Arduino API, so looks good.
However the count name is not intuitive.
Is it a int until_total_number_of_occurrences = 1 ?
Is it a
int until_total_number_of_occurrences = 1?
yes
Can you please add a comment or rename the variable ?
Can you please add a comment or rename the variable ?
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving: Next step is to simplify our calls to readStringUntil() from our libraries (especially but not only parsing-impl.h)
edit (or improve Stream::sendUntil() with this same new API) - see #9005)
...8266#9011) * add readStringUntil function with string terminator * rename count parameter to untilTotalNumberOfOccurrences
currently there is a
function, but there is no equivalent of it that uses string terminator. this pr implements
i found this useful for small html parsing or truncating.