-
Notifications
You must be signed in to change notification settings - Fork 3k
ssh: fix ssh_file:encode typespec #10539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CT Test Results
2 files 29 suites 20m 7s ⏱️
482 tests 476 ✅ 6 💤 0 ❌
1 687 runs 1 661 ✅ 26 💤 0 ❌
Results for commit caadeab.
♻️ This comment has been updated with latest results.
To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.
See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.
Artifacts
- Complete CT logs (Download Logs)
- HTML Documentation (Download HTML Docs)
- No Windows Installer found
// Erlang/OTP Github Action Bot
- Fixes erlang#10525 - related to commit b50e148 in public_key: Add missing macros and definitions
@IngelaAndin
IngelaAndin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. ssh_msg change is due to updating of public_key specs. You now get an enumeration atom with the new asn-1 specs instead of the enumeration number. The ssh file format I think you have better knowledge of than me.
- Add backward compatibility for ECPrivateKey version field * Support both integer 1 (OTP 26/27) and atom ecPrivkeyVer1 (OTP 28) * Fixes pattern match failures after public_key ASN.1 modernization - Split experimental_openssh_key_v1 typespec into encode/decode variants * experimental_openssh_key_v1_encode() - for encoding input * experimental_openssh_key_v1_decode() - for decoding output * Fixes type asymmetry between encode and decode flows - Add comprehensive compatibility test * Tests EdDSA curves: ed25519, ed448 * Tests ECDSA curves: secp256r1, secp384r1 * Verifies both version formats produce identical encoding - Code cleanup * Remove outdated comments * Fix whitespace and formatting * Update KeyPairs comment to document both tuple formats Related to commit b50e148 (public_key: Add missing macros and definitions) Fixes erlang#10525, erlang#10526
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe reverse the test as probably ecPrivKeyVer1 will be the value in new systems and value 1 will be the backwards compatibility that should not happen that much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the binary() , maybe it should say Comment::binary() ?
ssh_file:encodehas incorrect typespec foropenssh_key_v1#10526