-
Notifications
You must be signed in to change notification settings - Fork 31
Helper block for collision with group #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a 3-in-1 helper block for the common pattern found in the demos. It replaces adding: - A "when this node collides with ..." block - An "if" block - An "is node in group" block
Draft for now because our signal handlers have the same "on_SIGNAL" name.
Having two of these blocks will generate 2 functions with the same "_on_body_entered" callback, is this the problem you're talking about with the "on_SIGNAL" name?
If so, doesn't this problem already exist in the "when this node collides with .." block?
This will be a hard fix because you need a way to make the signal callback unique but we code the function name with code_template so in order for it to be unique it needs to be dynamically generated.
Having two of these blocks will generate 2 functions with the same "_on_body_entered" callback, is this the problem you're talking about with the "on_SIGNAL" name?
Yes, we need a better way. For example the Visual Shaders in Godot use suffixes (try creating a visual shader and then click "Show generated shader code". We'll need a solution like that.
This is a 3-in-1 helper block for the common pattern found in the demos. It replaces adding: