I'm 👎 on re-parsing the HTML with Nokogiri after generation. A quick check shows CodeRay already has a way to highlight lines

I'm OK to merge this if you can commit to investigating a better way to handle this sometime this week:

Possible solutions are one or more of:

• see if CodeRay highlighting already supports what we need (highlights of many types).
• fork CodeRay and add this, open a PR on CodeRay referencing this issue, open a PR here pointing at your fork.
• figuring out how to write and use a custom encoder for CodeRay.

@trek Makes sense. Let me investigate a little bit later today.

One thing to note: this repo already is using a Coderay fork: https://github.com/emberjs/guides/blob/master/Gemfile#L7

Will likely implement this as a custom encoder, using the HTML encoder as a base. Will report later how that is going

One thing to note: this repo already is using a Coderay fork:

Can you also follow up on that? I'm assuming this is just because we needed to add a language to mainline CodeRay and never changed back.

@trek Coderay lacks handlebars (@dgeb's PR) support. If I use mainline:
ember js - templates the application template 2015年03月24日 11-18-31

cc @dgeb: we really need to get that back to mainline.

Will report later how that is going

Is this later enough? :D

@trek Been sidetracked with an Ember-IE8 breakage. I should have some time this weekend to wrap this up. I have started a custom encoder, should be fine to implement what I need to make this happen. Sorry about the delay

OK. going to merge this now, trust that you'll circle back with a smoother solution.

Actually, belay that. Let's just wait until it's all done.