Skip to content

Navigation Menu

Sign in
Sign up

Simple ISO verification hashing done on the client - #3189

Draft
RMcNeely wants to merge 1 commit into
master from
download-verification
Draft

Simple ISO verification hashing done on the client #3189
RMcNeely wants to merge 1 commit into
master from
download-verification

Conversation

@RMcNeely

@RMcNeely RMcNeely commented Mar 1, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #3179

Initial pass at providing a client-side way to verify the downloaded ISO file. Needs a lot more love but posting as a POC so someone with an x86 computer can validate.

Changes Summary

  • Adds a page to verify the checksum of the download

This pull request is a draft that needs UI review

Copy link
Copy Markdown

@RMcNeely I am curious. Could you imagine showing a visual glimpse of the actual state of your POC?

RMcNeely commented Mar 8, 2023

Copy link
Copy Markdown
Contributor Author

I can add something to show progress but I'm not sure that the way it is written I can easily add a progress bar given that the APIs are async. I would need to rewrite the file read operation to use chunks but to my knowledge, there's no way to do chunking on the hash creation so at best you would have a progress bar for only one part of the workflow.

I think it would be simpler to add a message that changes with the different steps of the verification process. Something like:

  1. Reading ISO file
  2. Creating Hash
  3. Other? Stringifiying the hash and comparing it to an expected value would both be very quick operations. I'm not sure thats worth displaying something for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow verification of the OS download via the website itself

AltStyle によって変換されたページ (->オリジナル) /