Skip to content

Navigation Menu

Sign in
Sign up

Simplify search function - #1803

Draft
jeremypw wants to merge 4 commits into
master from
jeremypw/searchbar/simplify-search
Draft

Simplify search function #1803
jeremypw wants to merge 4 commits into
master from
jeremypw/searchbar/simplify-search

Conversation

@jeremypw

@jeremypw jeremypw commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Extracted from #1794 so that that PR does not contain any changes to the logic.

  • Remove unused function
  • SearchContext highlight always true
  • Merge part of has_matches () into search () and rely on rest to fail gracefully if there are no matches

@jeremypw jeremypw changed the title (削除) Simply search function (削除ここまで) (追記) Simplify search function (追記ここまで) Sep 3, 2026
@jeremypw jeremypw modified the milestones: 8.4, 8.4.x Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.4.x

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /