-
-
Notifications
You must be signed in to change notification settings - Fork 118
Open
Conversation
danirabbit
danirabbit
previously requested changes
Jan 29, 2026
@danirabbit
danirabbit
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be done alongside a version bump for Granite. Without the change in Granite.Services.ContractorProxy.get_contracts_for_file or it'll just break
@ryonakano
ryonakano
added
the
Status: Blocked
Something else needs to be done before this can be fixed
label
Jan 29, 2026
drowsymike
commented
Jan 30, 2026
Author
Good day. Yes, I didn't notice it yesterday. I fixed it today, and now there's only one file in Changed files (the changed file is io.elementary.code.yml)
This was referenced Jan 30, 2026
ryonakano
ryonakano
approved these changes
Aug 25, 2026
@ryonakano
ryonakano
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we need to wait newer Contractor to be released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
In discussions elementary/contractor#31 and elementary/contractor#41, @ryonakano pointed out the need to transition from
org.elementary.Contractortoio.elementary.Contractoras part of the RDNN rename for OS 9This PR updates the occurrences in
io.elementary.code.ymlanddata/code.metainfo.xml.into match the changes in the Contractor daemonNote: This change is part of a cross-repo transition and should be merged in coordination with the Contractor PR