-
-
Notifications
You must be signed in to change notification settings - Fork 611
feat: Publisher S3 add ChecksumCalculation#3903
Open
Dexus wants to merge 4 commits intoelectron:main from
Open
feat: Publisher S3 add ChecksumCalculation #3903Dexus wants to merge 4 commits intoelectron:main from
Dexus wants to merge 4 commits intoelectron:main from
Conversation
@Dexus
Dexus
changed the title
(削除) Allow modification of ChecksumCalculation (削除ここまで)
(追記) fix: Allow modification of ChecksumCalculation (追記ここまで)
Apr 1, 2025
@Dexus
Dexus
changed the title
(削除) fix: Allow modification of ChecksumCalculation (削除ここまで)
(追記) fix: Publisher S3 add ChecksumCalculation (追記ここまで)
Apr 29, 2025
@Dexus
Dexus
changed the title
(削除) fix: Publisher S3 add ChecksumCalculation (削除ここまで)
(追記) feat: Publisher S3 add ChecksumCalculation (追記ここまで)
Apr 29, 2025
Author
Dexus
commented
Apr 29, 2025
ping @erickzhao
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summarize your changes:
This pull request introduces new configuration options for checksum handling in the
PublisherS3class. The changes primarily focus on allowing users to control checksum calculations and validations for requests and responses to and from S3.This is local only tested against backblaze S3 and cloudflare R2.
Configuration Enhancements:
packages/publisher/s3/src/Config.ts: AddedrequestChecksumCalculationandresponseChecksumValidationoptions to thePublisherS3Configinterface. These options allow users to specify when checksums should be calculated and validated, respectively.Implementation Updates:
packages/publisher/s3/src/PublisherS3.ts: Updated thePublisherS3class to include the new checksum configuration options when creating the S3 client. Default values are set to "WHEN_SUPPORTED" if not provided.