Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: Publisher S3 add ChecksumCalculation#3903

Open
Dexus wants to merge 4 commits intoelectron:main from
deepnest-next:checksum
Open

feat: Publisher S3 add ChecksumCalculation #3903
Dexus wants to merge 4 commits intoelectron:main from
deepnest-next:checksum

Conversation

@Dexus
Copy link

@Dexus Dexus commented Apr 1, 2025
edited
Loading

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This pull request introduces new configuration options for checksum handling in the PublisherS3 class. The changes primarily focus on allowing users to control checksum calculations and validations for requests and responses to and from S3.

This is local only tested against backblaze S3 and cloudflare R2.

Configuration Enhancements:

  • packages/publisher/s3/src/Config.ts: Added requestChecksumCalculation and responseChecksumValidation options to the PublisherS3Config interface. These options allow users to specify when checksums should be calculated and validated, respectively.

Implementation Updates:

  • packages/publisher/s3/src/PublisherS3.ts: Updated the PublisherS3 class to include the new checksum configuration options when creating the S3 client. Default values are set to "WHEN_SUPPORTED" if not provided.

@Dexus Dexus requested a review from a team as a code owner April 1, 2025 08:29
@Dexus Dexus changed the title (削除) Allow modification of ChecksumCalculation (削除ここまで) (追記) fix: Allow modification of ChecksumCalculation (追記ここまで) Apr 1, 2025
@Dexus Dexus changed the title (削除) fix: Allow modification of ChecksumCalculation (削除ここまで) (追記) fix: Publisher S3 add ChecksumCalculation (追記ここまで) Apr 29, 2025
@Dexus Dexus changed the title (削除) fix: Publisher S3 add ChecksumCalculation (削除ここまで) (追記) feat: Publisher S3 add ChecksumCalculation (追記ここまで) Apr 29, 2025
Copy link
Author

Dexus commented Apr 29, 2025

ping @erickzhao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Comments

AltStyle によって変換されたページ (->オリジナル) /