Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test: migrate Enzyme tests to React Testing Library#1850

Closed
felixrieseberg wants to merge 1 commit intofelixr/react-18-core from
felixr/enzyme-to-rtl
Closed

test: migrate Enzyme tests to React Testing Library #1850
felixrieseberg wants to merge 1 commit intofelixr/react-18-core from
felixr/enzyme-to-rtl

Conversation

@felixrieseberg
Copy link
Member

@felixrieseberg felixrieseberg commented Feb 10, 2026

Summary

RTL replacements for all 21 Enzyme test files removed in #1849. This is a pure test-only PR — no source code changes.

Changes

All 21 test files rewritten from Enzyme (shallow/mount) to React Testing Library (render/screen/userEvent):

  • dialog-add-theme-spec, dialog-add-version-spec, dialog-bisect-spec
  • dialog-generic-spec, dialog-token-spec, dialogs-spec
  • header-spec, output-spec
  • settings-credits-spec, settings-electron-spec, settings-execution-spec
  • settings-general-appearance-spec, settings-general-block-accelerators-spec
  • settings-general-console-spec, settings-general-font-spec
  • settings-general-gist-spec, settings-general-github-spec
  • settings-general-mirror-spec, settings-general-spec
  • settings-spec, sidebar-package-manager-spec

Verification

  • tsc --noEmit: 0 errors
  • vitest run: 91 files, 806 passed (full coverage restored)

Add RTL replacements for all 21 Enzyme test files that were removed
in the React 18 upgrade. Tests use render/screen/userEvent from
@testing-library/react instead of shallow/mount from Enzyme.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Member Author

Splitting differently — RTL migration first, React 18 upgrade later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /