-
Notifications
You must be signed in to change notification settings - Fork 749
fix(versions); Handle Download Failures More Gracefully in Electron Fiddle#1837
Open
MohamedAli00949 wants to merge 5 commits intoelectron:main from
Open
fix(versions); Handle Download Failures More Gracefully in Electron Fiddle #1837MohamedAli00949 wants to merge 5 commits intoelectron:main from
MohamedAli00949 wants to merge 5 commits intoelectron:main from
Conversation
@MohamedAli00949
MohamedAli00949
requested review from
a team and
codebytere
as code owners
January 31, 2026 10:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor state versions to improve the error handling for downloading versions using the set version menu at the header, as at the video below with more understandable error messages and a retry mechanism with 3 attempts.
Also, while solving this issue, I have discovered another bug related to this issue. At first, the unexpected state of UI while startup if the setup version (based on previous usage of the app) is in state Downloading and no internet connection. So this has led me to refactor the app component class.
Target Issue
#1708
Video
Note: This video has a speed of almost 2.5 to make it smaller in size.
handle.download.failures.-.Made.with.Clipchamp.3.mp4