-
Notifications
You must be signed in to change notification settings - Fork 749
fix: ensures saved status only triggers if local path exists#1825
Open
amrkhaled104 wants to merge 1 commit intoelectron:main from
Open
fix: ensures saved status only triggers if local path exists #1825amrkhaled104 wants to merge 1 commit intoelectron:main from
amrkhaled104 wants to merge 1 commit intoelectron:main from
Conversation
@amrkhaled104
amrkhaled104
requested review from
a team and
codebytere
as code owners
December 23, 2025 20:23
Author
amrkhaled104
commented
Jan 26, 2026
Hi @dsanders11
Just following up on this PR. I'm happy to make any changes or address feedback if there's anything blocking the merge. Let me know if you need anything from my side
Thanks for your time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1821.
This PR ensures that Electron Fiddle only marks the editor as 'saved' after publishing a Gist if a local path exists. This prevents the unsaved indicator from disappearing when working on an unsaved Fiddle.