Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: improve UX handling when multiple main files detected#1700

Open
nilayarya wants to merge 2 commits intoelectron:main from
nilayarya:multi-main
Open

feat: improve UX handling when multiple main files detected #1700
nilayarya wants to merge 2 commits intoelectron:main from
nilayarya:multi-main

Conversation

@nilayarya
Copy link

@nilayarya nilayarya commented Apr 5, 2025 •
edited
Loading

Description of Change

Suggests UI changes to resolve #1508

  1. New MenuItem 'Set as Main Entry Point' available on right-click of valid main files (main.js, main.cjs, main.mjs)
  2. A Popup if there are multiple main files in the loaded fiddle (shows up only once a session )

Some gifs:

switchingsides


switcherooooo


showdialog

gist-url: https://gist.github.com/nilayarya/dfac02c9af5c699f3efc146ddf946f9f

CC @dsanders11

Checklist

  • PR description included and stakeholders cc'd
  • This PR was not created with AI. (PRs created mainly with AI will be closed. They waste our team's time. We ban repeat offenders.)
  • yarn test passes
  • tests are changed or added
  • PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

@nilayarya nilayarya requested review from a team and codebytere as code owners April 5, 2025 04:49
Copy link

Coverage Status

coverage: 87.482% (+0.01%) from 87.472%
when pulling 9c9e60d on nilayarya:multi-main
into d5e133f on electron:main.

Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nilayarya, thank you for your PR, but it seems to be incomplete. From the current PR, I can only temporarily consider this as an improvement for the edge case when there are multiple mainEntryPoints in the gist. When I create another mainEntryPoint from the left sidebar, it throws an error. According to the description in #1508, I believe @dsanders11 is hoping for a complete mainEntryPoint switching mechanism.

CleanShot 2025年07月23日 at 11 21 01
const entryPoint = this.mainEntryPointFile();
if (isMainEntryPoint(id) && entryPoint) {
throw new Error(
`Cannot add file "${id}": Main entry point ${entryPoint} exists`,
);
}

Comment on lines +358 to +365
if (!this.mainEntryPoint || !this.files.get(this.mainEntryPoint)) {
const entryPoint = Array.from(this.files.keys()).find((id) =>
isMainEntryPoint(id),
);
if (entryPoint) this.mainEntryPoint = entryPoint;
return entryPoint;
}
return this.mainEntryPoint;
Copy link
Member

@BlackHole1 BlackHole1 Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!this.mainEntryPoint || !this.files.get(this.mainEntryPoint)) {
const entryPoint = Array.from(this.files.keys()).find((id) =>
isMainEntryPoint(id),
);
if (entryPoint) this.mainEntryPoint = entryPoint;
return entryPoint;
}
return this.mainEntryPoint;
public mainEntryPointFile(): EditorId | null {
if (this.mainEntryPoint && this.files.get(this.mainEntryPoint)) {
return this.mainEntryPoint;
}
for (const [id] of this.files) {
if (isMainEntryPoint(id)) {
this.mainEntryPoint = id;
break;
}
}
return this.mainEntryPoint;

Make the code more intuitive and optimize performance a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BlackHole1 BlackHole1 BlackHole1 requested changes

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve UX Handling if Multiple Main Files

AltStyle によって変換されたページ (->オリジナル) /