Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix ArgumentError when calling dup on aggregations #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Copy link
Contributor

@rafayqayyum rafayqayyum commented Mar 4, 2025

This PR fixes an issue where calling .dup on aggregations in elasticsearch-rails results in the following error:

ArgumentError Exception: wrong number of arguments (given 2, expected 0..1)

Testing

Verified that .dup now works correctly on aggregations.
Ensured no breaking changes in existing functionality.

Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
a976b7c

Please, read and sign the above mentioned agreement if you want to contribute to this project

@rafayqayyum rafayqayyum marked this pull request as draft March 4, 2025 14:48
@rafayqayyum rafayqayyum marked this pull request as ready for review March 4, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /