Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix error while doing bundle error. Branch name is changed from maste... #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonianand11 wants to merge 1 commit into elastic:main
base: main
Choose a base branch
Loading
from sonianand11:fix_errors

Conversation

Copy link

@sonianand11 sonianand11 commented Dec 27, 2021
edited
Loading

  • Since the branch name is changed to main from master, bundle install was giving an error in elasticsearch-persistance app which is fixed with specifying branch name
  • Fix the error undefined method each_with_hit for Hash

Copy link

cla-checker-service bot commented Dec 27, 2021
edited
Loading

💚 CLA has been signed

Copy link
Author

@picandocodigo can you please review this PR?

Copy link
Member

Hi @sonianand11,
Thanks for submitting this PR. GitHub has some features in place to redirect to main when there's a request to master and it seems to be working as expected with bundler for me. What error were you getting when running bundle install and what versions of Bundler and Ruby were you using?

Copy link
Author

sonianand11 commented Dec 29, 2021
edited
Loading

@picandocodigo Thank you for quick response.
Current ruby version is ruby 2.7.2p137 (2020年10月01日 revision 5445e04352) [x86_64-linux]
I am using bundler version 2.1.4 and here is the error

Fetching https://github.com/elastic/elasticsearch-rails.git
fatal: Needed a single revision
Git error: command `git rev-parse --verify master` in directory

I am executing bundle install inside examples directory i.e. elasticsearch-rails/elasticsearch-persistence/examples/notes

If I do git branch in elasticsearch-rails/elasticsearch-persistence/examples/notes it is showing main branch instead of master since we already have changed that.

Copy link
Contributor

Hi @sonianand11. If you update Bundler to a version >= 2.2.5, it will just work and there's no need to change the Gemfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /