-
Notifications
You must be signed in to change notification settings - Fork 618
Typo in RTS signal for UART0 #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Mani-Sadhasivam
Mani-Sadhasivam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @focalplane,
Change looks good but as per MRAA contribution guidelines you need to rework this PR. https://github.com/intel-iot-devkit/mraa/blob/master/CONTRIBUTING.md#basic-rules
alext-mkrs
commented
Mar 2, 2019
@focalplane thanks for your correction, but yes, specifically, please add a sign-off line into your commit message and add an affected file/module name into the commit message summary. The link @Mani-Sadhasivam shared is the full information on that.
No description provided.