-
Notifications
You must be signed in to change notification settings - Fork 31
Open
Conversation
...of the redis (or other data store) connections for long running processes.
eaigner
commented
Feb 27, 2016
Owner
Thanks for the PR. Wouldn't it be better though to let shield automatically reconnect instead of exposing a TestConnection to the user?
mikeflynn
commented
Feb 28, 2016
Author
Yup, I had a similar thought...but I ended up not going that route as we would have to have a new setting to tweak how often it should check/reset and would add a thread to check for the reset timer even for applications that were just running in a one off and didn't need it. In the end, I figured I would just offload that logic to the apps that decided they wanted it, but it could certainly go the other way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using this library as part of a service and I've seen it lose the Redis connection, so I added a simple method on the store (and the related interfaces) to query and reset the connection as needed.
This could apply to any other data store over the network, but could also just be a nil function for stores that don't need a connection reset.