Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix markdown fail issue#42 #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwylbot merged 6 commits into master from fix-markdown-fail-issue#42
Jul 5, 2018
Merged

Fix markdown fail issue#42 #43

dwylbot merged 6 commits into master from fix-markdown-fail-issue#42
Jul 5, 2018

Conversation

Copy link
Member

@nelsonic nelsonic commented Jun 19, 2018

see: #42
fixed:
image

package.json Outdated
"start": "live-server --port=8000 --open=./examples",
"test": "istanbul cover test/test.js",
"check-coverage": "istanbul cover test/test.js && istanbul check-coverage --statements 100 --functions 100 --lines 100 --branches 100",
"postinstall": "npm test && npm start",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to delete this line as it causes the build to "hang" (unsurprisingly, in retrospect! doh!)
https://travis-ci.org/dwyl/learn-elm-architecture-in-javascript/builds/394115145#L551

Copy link
Collaborator

@dwylbot dwylbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
image

@dwylbot dwylbot merged commit 814467e into master Jul 5, 2018
@dwylbot dwylbot deleted the fix-markdown-fail-issue#42 branch July 5, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwylbot dwylbot dwylbot approved these changes

@iteles iteles Awaiting requested review from iteles

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /