-
Notifications
You must be signed in to change notification settings - Fork 22
Multiple counters issue#40 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...0] } (Object) instead of model = 0 (Integer) for #40
Codecov Report
@@ Coverage Diff @@ ## master #41 +/- ## ===================================== Coverage 100% 100% ===================================== Files 1 1 Lines 43 44 +1 ===================================== + Hits 43 44 +1
Continue to review full report at Codecov.
|
w0rm
commented
Jun 11, 2018
@nelsonic I’m not the author of this illustration, please provide correct credits. https://twitter.com/01k/status/986528602635358208?s=20
...C BY 4.0) for superb image by @w0rm see: #41 (comment)
@w0rm thank you for taking time to comment, 🎉
I have added the (CC BY 4.0) attribution below the image. ✅
Fantastic drawing BTW! ❤️
and great work on the Game tutorial: https://github.com/w0rm/creating-a-fun-game-with-elm 👾
and presentation: https://unsoundscapes.com/slides/2016-10-13-creating-a-fun-game-with-elm 💎
README.md
Outdated
@w0rm
w0rm
Jun 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not my illustration and should not mention my name, Kolja Wilcke https://twitter.com/01k made it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@w0rm got it. thanks for clarifying. fixed. 👍
w0rm
commented
Jun 11, 2018
@nelsonic thanks for correcting the attribution. All the credits should really go to Kolja.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nelsonic LGTM! 🤖 ✅
Working on adding Multiple Counters with tests for #40 ...
will assign when ready for review. 👍