Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

TDD section updates #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nelsonic merged 3 commits into dwyl:master from finnhodgkin:tdd-section-fixes
Jun 12, 2017
Merged

TDD section updates #31

nelsonic merged 3 commits into dwyl:master from finnhodgkin:tdd-section-fixes
Jun 12, 2017

Conversation

Copy link
Collaborator

@finnhodgkin finnhodgkin commented Jun 12, 2017

Adds a few tweaks to the TDD sections of the readme and to the example test file.
fixes #30

to match a premade css button class and the rest of the text. dwyl#30 
... DOM
Previously it would fail when the reset button was added.
dwyl#30 
Copy link

codecov bot commented Jun 12, 2017
edited
Loading

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #31 +/- ##
=====================================
 Coverage 100% 100% 
=====================================
 Files 1 1 
 Lines 43 43 
=====================================
 Hits 43 43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17b772...f6f2204. Read the comment docs.

Adds syntax highlighting, fixes the way the mount function is called
(straight arguments instead of an options object), removes a console.log
and clears the test DOM dwyl#30 
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finnhodgkin thanks very much for making these updates/clarifications. 🎉

@nelsonic nelsonic merged commit 8ed2e35 into dwyl:master Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear sections in the TDD portion

AltStyle によって変換されたページ (->オリジナル) /