Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Address Review Comments #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iteles merged 11 commits into master from address-rjmk-comments
May 14, 2017
Merged

Address Review Comments #19

iteles merged 11 commits into master from address-rjmk-comments
May 14, 2017

Conversation

Copy link
Member

@nelsonic nelsonic commented May 13, 2017

This PR addresses comments made in #11 and #14

nelsonic added 7 commits May 13, 2017 22:16
Copy link

codecov-io commented May 14, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7d280a8). Click here to learn what that means.
The diff coverage is 83.33%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #19 +/- ##
=========================================
 Coverage ? 95.34% 
=========================================
 Files ? 1 
 Lines ? 43 
 Branches ? 0 
=========================================
 Hits ? 41 
 Misses ? 2 
 Partials ? 0
Impacted Files Coverage Δ
examples/counter-reset/counter.js 95.34% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d280a8...acb9f60. Read the comment docs.

Copy link
Member Author

@iteles I'm not going to do any more work on this PR.
I added some basic tests but go stuck on #20
Don't really see a benefit to spending more time on figuring out why JSDOM Click isn't working!
because we aint gonna use it for any dwyl project.
Please review and merge when you can. thanks.

Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into these @nelsonic!
Agreed, no point into sinking more time into the click 👍

@iteles iteles merged commit 09e7bf6 into master May 14, 2017
@iteles iteles deleted the address-rjmk-comments branch May 14, 2017 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteles iteles iteles approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /