-
Notifications
You must be signed in to change notification settings - Fork 255
Comments
Prefix classes needed for JS functionality with 'js-'#743
Open
gauravjeet wants to merge 1 commit intodrupalcommerce:8.x-2.x from
Open
Prefix classes needed for JS functionality with 'js-' #743gauravjeet wants to merge 1 commit intodrupalcommerce:8.x-2.x from
gauravjeet wants to merge 1 commit intodrupalcommerce:8.x-2.x from
Conversation
mglaman
mglaman
requested changes
Jun 22, 2017
Contributor
@mglaman
mglaman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add the js- class name along with the existing. Just because people will be theming against the existing CSS classes. @bojanz thoughts?
*/
function template_preprocess_commerce_cart_block(&$variables) {
$variables['attributes']['class'][] = 'cart--cart-block';
$variables['attributes']['class'][] = 'js-cart--cart-block';
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also keep the non js- variant? for theming
],
'#attributes' => [
'class' => ['checkout-pane-overview'],
'class' => ['js-checkout-pane-overview'],
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
public static function processRedirectForm(array $element, FormStateInterface $form_state, array &$complete_form) {
$complete_form['#action'] = $element['#action'];
$complete_form['#attributes']['class'][] = 'payment-redirect-form';
$complete_form['#attributes']['class'][] = 'js-payment-redirect-form';
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous
@bojanz
bojanz
force-pushed
the
8.x-2.x
branch
from
August 10, 2017 17:37
5b3779b to
2941d08
Compare
@bojanz
bojanz
force-pushed
the
8.x-2.x
branch
from
September 12, 2017 23:36
53ec70a to
3bc1b88
Compare
@bojanz
bojanz
force-pushed
the
8.x-2.x
branch
from
October 8, 2018 15:18
807c6e8 to
8898142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.drupal.org/node/2877358