-
Notifications
You must be signed in to change notification settings - Fork 255
Comments
Issue #2857378 by bojanz, vasike, mglaman: Hide order activity when empty#666
Open
vasike wants to merge 16 commits intodrupalcommerce:8.x-2.x from
Open
Issue #2857378 by bojanz, vasike, mglaman: Hide order activity when empty #666vasike wants to merge 16 commits intodrupalcommerce:8.x-2.x from
vasike wants to merge 16 commits intodrupalcommerce:8.x-2.x from
Conversation
Contributor
mglaman
commented
Mar 9, 2017
phpcs issues
The command "phpcs --standard=phpcs.xml src -s" exited with 0.
7.39s$ phpcs --standard=phpcs.xml modules -s
FILE: ...erce/modules/log/tests/src/Functional/OrderAdminActivityTest.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
17 | ERROR | [x] Do not append variable name "$order" to the type
| | declaration in a member variable comment
| | (Drupal.Commenting.VariableComment.InlineVariableName)
68 | ERROR | [x] Expected 1 blank line after function; 0 found
| | (Squiz.WhiteSpace.FunctionSpacing.After)
69 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
| | (Drupal.Classes.ClassDeclaration.CloseBraceAfterBody)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
...o 2857378-order-activity-empty
...o 2857378-order-activity-empty
...o 2857378-order-activity-empty
...mpty total price
Contributor
Author
vasike
commented
Apr 6, 2017
it seems this fails because of this
#711
issue: https://www.drupal.org/node/2867430
@bojanz
bojanz
force-pushed
the
8.x-2.x
branch
5 times, most recently
from
April 21, 2017 19:23
1028fc1 to
005e904
Compare
...o 2857378-order-activity-empty
...o 2857378-order-activity-empty
...com:vasike/commerce into 2857378-order-activity-empty
...o 2857378-order-activity-empty
@bojanz
bojanz
force-pushed
the
8.x-2.x
branch
2 times, most recently
from
April 27, 2017 20:46
6be1d5c to
b8a7444
Compare
...o 2857378-order-activity-empty
@bojanz
bojanz
force-pushed
the
8.x-2.x
branch
from
August 10, 2017 17:37
5b3779b to
2941d08
Compare
@bojanz
bojanz
force-pushed
the
8.x-2.x
branch
from
September 12, 2017 23:36
53ec70a to
3bc1b88
Compare
...o 2857378-order-activity-empty
...o 2857378-order-activity-empty
@bojanz
bojanz
force-pushed
the
8.x-2.x
branch
from
October 8, 2018 15:18
807c6e8 to
8898142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.