-
Notifications
You must be signed in to change notification settings - Fork 255
Issue #2846890: Create a log entry when item is removed from cart or qty is changed programatically#625
Open
GoZOo wants to merge 3 commits intodrupalcommerce:8.x-2.x from
Open
Issue #2846890: Create a log entry when item is removed from cart or qty is changed programatically #625GoZOo wants to merge 3 commits intodrupalcommerce:8.x-2.x from
GoZOo wants to merge 3 commits intodrupalcommerce:8.x-2.x from
Conversation
...qty is changed programatically
cart_item_quantity_changed:
category: commerce_cart
label: 'Quantity changed from cart'
template: '<p>Quantity for <em>{{ purchased_entity_label }}</em> changed in the cart form <em>{{ original_quantity }} to {{ quantity }}</em>.</p>'
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "Quantity for" to "Quantity of".
No emphasis around the quantities.
And "form" should be "from".
Contributor
steveoliver
commented
Feb 1, 2017
This looks good, @GoZOo - think you could create a test for this in https://github.com/drupalcommerce/commerce/blob/8.x-2.x/modules/log/tests/src/Kernel/CartIntegrationTest.php ? Then I'd say this is good to go.
Contributor
Author
GoZOo
commented
Feb 1, 2017
You are right, I completely miss the tests
Contributor
Author
Note that we'll have to update this PR or #628 depending of witch one is commited first.
Contributor
steveoliver
commented
Feb 21, 2017
Needs work. See last fail.
@bojanz
bojanz
force-pushed
the
8.x-2.x
branch
7 times, most recently
from
April 27, 2017 20:46
6be1d5c to
b8a7444
Compare
@bojanz
bojanz
force-pushed
the
8.x-2.x
branch
from
August 10, 2017 17:37
5b3779b to
2941d08
Compare
@bojanz
bojanz
force-pushed
the
8.x-2.x
branch
from
September 12, 2017 23:36
53ec70a to
3bc1b88
Compare
@bojanz
bojanz
force-pushed
the
8.x-2.x
branch
from
October 8, 2018 15:18
807c6e8 to
8898142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue https://www.drupal.org/node/2846890