Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix for google app engine#8

Open
sserrano44 wants to merge 1 commit into
dropbox:master from
sserrano44:master
Open

fix for google app engine #8
sserrano44 wants to merge 1 commit into
dropbox:master from
sserrano44:master

Conversation

@sserrano44

@sserrano44 sserrano44 commented Mar 4, 2014

Copy link
Copy Markdown

pkg_resources is not available

Comment thread zxcvbn/matching.py

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, pkg_resources is better for this purpose because provides support for accessing data files residing in the module even when the module is actually loaded from a zipfile. This request drops that ability.

I imagine that pkg_resources is not available on Google App Engine since it's not standard? But in order to not regress the behavior, could you please modify this pull request to try to import and use the pkg_resources method, and if it fails, fall back to using the filesystem?

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /