-
Notifications
You must be signed in to change notification settings - Fork 553
Added timeout parameter for Connection class #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bit-sam
bit-sam
changed the title
(削除) Added timeout for connection (削除ここまで)
(追記) Added timeout parameter for Connection class (追記ここまで)
Oct 5, 2021
CLA assistant check
All committers have signed the CLA.
psantacl
psantacl
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Pyhive does not support custom connection timeout, and user may have to wait long time-period unwillingly before an exception is raised.
This PR would add an extra optional parameter
timeouttoConnectionclass which would allow users to set custom timeout for hive connections.How:
This PR exposes the underlying timeout functionality of
TSocketandTHttpClienttoConnectionclass for the users which add extra flexibility for advanced users, who might need more flexibility, and is also backward compatible