-
Notifications
You must be signed in to change notification settings - Fork 115
Open
Conversation
Guflly
commented
Jul 28, 2026
Author
@dotnet-policy-service agree
kartheekp-ms
kartheekp-ms
requested changes
Aug 11, 2026
@kartheekp-ms
kartheekp-ms
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Guflly please rebase since we migrated tests from Moq to NSubstitute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #998.
Rejects raw
#characters in OPC part names before signing instead of producing an invalid signature. The tests cover both root and nested entries and verify that no signature is left behind.This follows the approach in #1042, which was closed before review.
eng/common/Build.ps1 -restore -build -test -sign -pack -publish -cipasses.