-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Fix Tizen linking flags used during ILCompiler build#129844
Conversation
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.
am11
commented
Jun 25, 2026
Looks good. Is it for cross-publish only or does it work on Tizen machine as well (assuming SDK works on Tizen)?
gbalykov
commented
Jun 25, 2026
Is it for cross-publish only or does it work on Tizen machine as well (assuming SDK works on Tizen)?
Currently I'm checking cross build case. CrossCompileArch is used for cross/native builds check in src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets, however, CrossCompileArch is only set if _hostArchitecture != _targetArchitecture. This is not true for cross build to tizen x64, that's why there's no such check in this patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these things really necessary? We have not been passing standard library paths in other platforms. We pass --sysroot which should set these things up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these maybe necessary, since Tizen might not be using regular/defacto locations in some cases (clang defines them at: https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Gnu.cpp). @gbalykov, could you please try removing a line, then publish an app on armv7l, arm64 and x64 to see if that line was needed; rinse and repeat to minimize this patch? Typically we only need a few linker related args not everything which was needed to build runtime repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've minimized the patch keeping only what's required. Checked this on runtime build, no issues. Sysroot is passed even without this change, but that's not enough.
Without this change linker flags set in src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets in SetupOSSpecificProps do not consider tizen platform specifics, which are set in toolchain.cmake.
cb38d60 to
5460876
Compare
Without this change linker flags set in src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets in SetupOSSpecificProps do not consider tizen platform specifics, which are set in toolchain.cmake.