-
Notifications
You must be signed in to change notification settings - Fork 714
fix(ApiExplorer): SubstitutedType have invalid property setter #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AndreaCuneo
wants to merge
1
commit into
dotnet:main
from
ARKlab:bugfix/SubstituteTypeInvalidPropertySetter
Open
fix(ApiExplorer): SubstitutedType have invalid property setter #1105
AndreaCuneo
wants to merge
1
commit into
dotnet:main
from
ARKlab:bugfix/SubstituteTypeInvalidPropertySetter
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dotnet-policy-service agree
The PropertySetter of the SubstitutedType have 0 parameters: they had the same signature of the Getter. resolves: dotnet#1104
@AndreaCuneo
AndreaCuneo
force-pushed
the
bugfix/SubstituteTypeInvalidPropertySetter
branch
from
August 28, 2024 09:52
27ac7c3 to
41f8cda
Compare
@commonsensesoftware can you please take a look. is a 1 line change plus tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(ApiExplorer): SubstitutedType have invalid property setter
Description
The PropertySetter of the SubstitutedType properties have 0 parameters: they had the same signature of the Getter.
Fixes #1104