-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Conversation
Author
ghost
commented
Oct 30, 2017
I made a scond commit.
Owner
dotWee
commented
Nov 3, 2017
I'm actually against this solution, as Google advices to avoid scrolling content within dialogs. See the Material Design Guidelines Dialogs-behavior as reference.
To fix your and the #9 issue, a full screen dialog (as described also within the official guidelines here) seems to be the best solution.
I'm currently busy on working on other projects, so this has low-priority for me. In case you're still interested in creating a fix, you could try to implement a custom and responsive full-screen layout that I'll merge into the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There are still bugs. If you're interrested I create a second pull request, when I solved it.
Thanks for your grat app. I've found it on F-Droid.
I changed the layout of the main dialog. This will also solve #9 (if I understood right). I had the problem also, when the content consists of long text. This is also the reason why title and content have now their own column.
Here a screenshot from my changes:
screenshot_20171030-195635