-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
feat(githubCorner): add width and height attributes #1992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add width and height attribute. This fixes jumping of the SVG for loading for slow connections.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 43e3109:
|
Tests are not running for some reason.
Changing bases to main and back to develop fixed it (same issue I've had in other projects, changing base always works).
This will conflict with
We'll merge that one first.
Summary
Add width and height attribute.
This fixes jumping of the SVG for loading for slow connections.
Here is a video showing this behavior for the zod documentation:
Screen.Recording.2023年02月17日.at.14.55.08.mp4
This adds width and height attributes to the github corner svg so that the intrinsic size is defined. See also https://web.dev/optimize-cls/#modern-best-practice. This does not prevent overwriting the size via CSS later so it shouldn't break any user CSS.
What kind of change does this PR introduce?
Bugfix
For any code change,
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Related issue, if any:
Tested in the following browsers: