-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
feat: collapse root sidsebar items #1979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: collapse root sidsebar items #1979
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2daba85:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this change for ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text is the entire compiled html of the sidebar.
The first "ul" is an element that contains the entire sidebar menu.
So I tried to give a class to the rest of the "ul" except the first "ul".
캡처_2023_02_05_19_16_53_1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
text is the entire compiled html of the sidebar. The first "ul" is an element that contains the entire sidebar menu. So I tried to give a class to the rest of the "ul" except the first "ul". 캡처_2023_02_05_19_16_53_1
I see, you gonna treat the parent sidebar node as the sub-sidebar of the root ul.
But the class .app-sub-sidebar you marked get the style change as well.
Before:
image
After:
image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could marked those parent sidebar nodes with new style app-sidebar and refactor the click event function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, implementing it with onClick seems to be a dual implementation method for one feature.
So I implemented it by className, which is the way used before.
.../proke03/docsify into feat/collapse-root-sidebar-items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Can you please:
- ensure the top-level items seem like they are clickable (instead of seeming like selectable text), using for example
cursor: pointer. - write a test for the functionality
- We need to ensure docsify-themeable doesn't break with this. Add a new
docsify-themeable.htmlfile that uses docsify-themeable so we can verify. Perhaps we should do this first in a separate PR.
@trusktr
The themeable file is an extension of docsify.
In themeable, style is specified.
So, in order for changes in docsify to be applied without changing themeable, the id and class values previously specified in themeable must not be applied elsewhere.
Is my understanding correct?
@proke03 basically the docsify-themeable CSS depends on the DOM of Docsify.
I think what we should do is in a totally separate pull request lets get a docsify-themeable deployment for n Vercel going, and then it will be available to all PR similar to our current Vercel deployment with vanilla Docsify.
Uh oh!
There was an error while loading. Please reload this page.
Summary
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Related issue, if any:
#900
Tested in the following browsers: