Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix: files from basePath should be remoteUrl:false #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
b6pzeusbc54tvhw5jgpyw8pwz2x6gs wants to merge 1 commit into docsifyjs:develop
base: develop
Choose a base branch
Loading
from b6pzeusbc54tvhw5jgpyw8pwz2x6gs:1659-fix-problem-script-not-running-when-using-basePath

Conversation

Copy link

@b6pzeusbc54tvhw5jgpyw8pwz2x6gs b6pzeusbc54tvhw5jgpyw8pwz2x6gs commented Nov 3, 2021 •
edited
Loading

Summary

When using the basePath as an absolute url including the domain and the domain of index.html and the domain of basePath are different, Currently, files fetched from basePath are treated as isExternal: true , and I think this behavior is a bug.

basePath is a value that can be entered only with the authority of the document site administrator, and the basePath server can also be considered owned by the administrator, so the isRemoteUrl value should be false.

What kind of change does this PR introduce?

Bugfix

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

#1659

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Copy link

vercel bot commented Nov 3, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/9PEsj4Y74qkJAhpihAttVtDSSv1y
✅ Preview: https://docsify-preview-git-fork-b6pzeusbc54tvhw5jg-bd121d-docsify-core.vercel.app

Copy link

codesandbox-ci bot commented Nov 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 16b5ba5:

Sandbox Source
docsify-template Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /