Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Update CONTRIBUTING.md #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trusktr wants to merge 4 commits into develop
base: develop
Choose a base branch
Loading
from update-contributing
Open

Update CONTRIBUTING.md #1532

trusktr wants to merge 4 commits into develop from update-contributing

Conversation

Copy link
Member

@trusktr trusktr commented Mar 9, 2021 •
edited
Loading

Summary

This is a small change to mention pull request templates in CONTRIBUTING.md, and to show what the new template look likes.

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

Copy link

vercel bot commented Mar 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/5Y9HaWxFxACEz7ZM3P2uhuHmed5D
✅ Preview: https://docsify-preview-git-update-contributing-docsify-core.vercel.app

Copy link
Member Author

trusktr commented Mar 9, 2021

Hmm, it still feels a bit noisy. 🤔

Copy link

codesandbox-ci bot commented Mar 9, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5dab7fa:

Sandbox Source
docsify-template Configuration

Copy link
Member

sy-records commented Mar 9, 2021 •
edited
Loading

We can merge these two

What kind of change does this PR introduce? and Does this PR introduce a breaking change? (check one)

Can this be removed and a comment added to the Summary?

Related issue, if any:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koooooo-7 Koooooo-7 Koooooo-7 left review comments

@sy-records sy-records sy-records left review comments

At least 2 approving reviews are required to merge this pull request.

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /