-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix #1422 #1423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1422 #1423
Conversation
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/3my2ep9BKksh42wYXVso66vg9KLo
✅ Preview: https://docsify-preview-git-fork-cmbaatz-develop-docsify-core.vercel.app
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8b7e895:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the xhr.withCredentials = true;, the request can bring the cookies for authenticaiton in headers for the cross-origin request.
IMO, it's an unsafe operation/setting, maybe it could be better to be an option on dev env.
I agree with @Koooooo-7. We can't default to settings withCredentials to true.
My initial thought is that modifying the xhr object is best handled via a new hook instead of a configuration option. This provides greater flexibility, including the ability to modify the xhr object based on the request URL:
window.$docsify = { plugins: [ function(hook, vm) { hook.beforeRequest(function(xhr, url) { // Domain-specific XHR settings if (/some-domain.com/.test(url)) { xhr.withCredentials = true; xhr.setRequestHeader("foo", "1"); xhr.setRequestHeader("bar", "2"); } }); } ] };
Thoughts @docsifyjs/core ?
I agree with @jhildenbiddle , Our config is getting huge lately. We need some kind of solution to limit that and customize futher.
I agree with the hook and custom plugin.
@cmbaatz please create an issue with the details and we can have a discussion there.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.