-
-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Conversation
ohmyfelix
force-pushed
the
chore/ci-rollout-baseline
branch
from
June 3, 2026 14:06
4904d79 to
fbb174c
Compare
ohmyfelix
force-pushed
the
chore/ci-rollout-baseline
branch
from
June 5, 2026 11:45
74759d3 to
9e37947
Compare
ohmyfelix
commented
Jun 8, 2026
Contributor
Author
Added CI fix commit: rebase Expose image from Buster/PHP 8.0 to Bullseye/PHP 8.2.
f3l1x
commented
Jun 16, 2026
Member
Suggested change: run CI on PRs, but keep publish strictly master-only
Right now this workflow has no pull_request trigger, so the Test job never validates the PR — and the publish (Build) job calls the reusable workflow with secrets: inherit with no master guard. Adding pull_request without guarding the publish job would expose registry secrets on every PR.
Two changes fix both:
on: workflow_dispatch: + + pull_request: push: branches: ["master"] @@ build: name: "Build" needs: ["test"] + if: github.ref == 'refs/heads/master' uses: dockette/.github/.github/workflows/docker.yml@master secrets: inherit
Result: a PR runs only the Test job (builds the image locally with load: true, runs make test, no secrets); Build (publish) and Docs run only on master. This matches the canonical shape already used in dockette/mockbin#2 and dockette/perl#2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why