Skip to content

Navigation Menu

Sign in
Sign up

Add Dockette CI rollout baseline - #2

Open
ohmyfelix wants to merge 8 commits into
dockette:master from
ohmyfelix:chore/ci-rollout-baseline
Open

Add Dockette CI rollout baseline #2
ohmyfelix wants to merge 8 commits into
dockette:master from
ohmyfelix:chore/ci-rollout-baseline

Conversation

@ohmyfelix

@ohmyfelix ohmyfelix commented May 29, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Added Test, Build, and Docs jobs to the Docker workflow.
  • Added baseline Makefile build, test, and run aliases while preserving existing helper targets.
  • Normalized README badges to the dockette/copybara style and added the standard Maintenance section.

Why

  • Aligns dockette/expose with the Dockette CI rollout baseline and keeps Docker Hub documentation updated.

ohmyfelix force-pushed the chore/ci-rollout-baseline branch from 4904d79 to fbb174c Compare June 3, 2026 14:06
ohmyfelix force-pushed the chore/ci-rollout-baseline branch from 74759d3 to 9e37947 Compare June 5, 2026 11:45

Copy link
Copy Markdown
Contributor Author

Added CI fix commit: rebase Expose image from Buster/PHP 8.0 to Bullseye/PHP 8.2.

f3l1x commented Jun 16, 2026

Copy link
Copy Markdown
Member

Suggested change: run CI on PRs, but keep publish strictly master-only

Right now this workflow has no pull_request trigger, so the Test job never validates the PR — and the publish (Build) job calls the reusable workflow with secrets: inherit with no master guard. Adding pull_request without guarding the publish job would expose registry secrets on every PR.

Two changes fix both:

 on:
 workflow_dispatch:
+
+ pull_request:
 push:
 branches: ["master"]
@@
 build:
 name: "Build"
 needs: ["test"]
+ if: github.ref == 'refs/heads/master'
 uses: dockette/.github/.github/workflows/docker.yml@master
 secrets: inherit

Result: a PR runs only the Test job (builds the image locally with load: true, runs make test, no secrets); Build (publish) and Docs run only on master. This matches the canonical shape already used in dockette/mockbin#2 and dockette/perl#2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /