-
Notifications
You must be signed in to change notification settings - Fork 203
Open
Conversation
GordonTheTurtle
commented
Sep 21, 2017
Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix-etcd-lock" git@github.com:9sheng/libkv.git somewhere $ cd somewhere $ git commit --amend -s --no-edit $ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use
github.com/docker/leadershipwith etcd store. When there is only 1 candidate, if the networks break down(i.e. use iptables) and then recover, the candidate cannot get the lock.The reason is that if the candidate is waiting for the lock when networks recover, the wait will never return. since no other candidate exists, the lock node will NEVER be changed.