-
Notifications
You must be signed in to change notification settings - Fork 325
fix(pi-fff): avoid blocking session start during finder warmup#478
Open
cokekitten wants to merge 1 commit into
Open
fix(pi-fff): avoid blocking session start during finder warmup #478cokekitten wants to merge 1 commit into
cokekitten wants to merge 1 commit into
Conversation
dmtrKovalenko
dmtrKovalenko
approved these changes
May 18, 2026
finderCwd = cwd;
await finder.waitForScan(15000);
return finder;
await createdFinder.waitForScan(15000);
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to actually get rid of the wait we proably should redesign the waitForScan internally, it is anyway blocking now while it should do the pool for is_scanning
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. This PR only removes the session_start blocking path; waitForScan itself can still block the first tool use. I kept the scope small here, but happy to follow up with a separate PR redesigning waitForScan to poll is_scanning internally if you prefer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #477.
pi-fffcurrently awaitsensureFinder()duringsession_start, andensureFinder()callsFileFinder.create()followed bywaitForScan(15000). Since Pi recreates the session runtime for/newand/resume, this can make session switching appear stuck while the finder scan warms up.This change:
session_startreturns, so Pi session replacement is not blockedfinderPromiseif warmup is not done yetcreatedFinderfromensureFinder()afterwaitForScan()to avoid returning a destroyed/replaced global finder if shutdown happens during warmupValidation
cd packages/pi-fff npx tsc --noEmit