-
Notifications
You must be signed in to change notification settings - Fork 55
Format DSF text in copyright #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@priyapahwa
priyapahwa
commented
Feb 12, 2024
- Add space between Software Foundation
- Underline links for DSF & registered trademark
- Add space between Software Foundation - Underline links for DSF & registered trademark Signed-off-by: Priya Pahwa <pahwa.priya19@gmail.com>
Hi and thanks for the pull request!
I'm impressed you spotted the missing space in the footer, I didn't know anyone actually read that 😅
For the underlining, I would prefer to do it in CSS instead of using <u> in the HTML. That will require modifying the file at scss/trachacks.scss. I've done a quick check and it seems we have two options:
- Add the underline in the
a:link, a:visitedselector near the beginning. This undoes the styling that Trac does on all links where it removes the underline, but has the consequence that almost all links now have an underline on the page. Personally I don't mind, but it does affect a lot of pages. - Add a more restricted selector, maybe something like
.footer a, or even.footer .copyright a. This fixes the lack of underline in the footer only, but has the slight disadvantage that it's yet another customization of the style that ideally would be handled only beoutput.css(which we originally copied from django/djangoproject.com).
Do you have an opinion on what would be the better option of the two? Or maybe a third idea?
Thanks! ✨
Hey @bmispelon,
Thanks for the detailed feedback. I'll look into this and get back to you in a while :)