Updated Trac query styling to be more compact and support mobile. #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

sarahboyce wants to merge 2 commits into django:main

from sarahboyce:update-query-ui

Open

Updated Trac query styling to be more compact and support mobile. #142

sarahboyce wants to merge 2 commits into django:main from sarahboyce:update-query-ui

Conversation

sarahboyce

Copy link

Contributor

@sarahboyce sarahboyce commented Jun 24, 2023 •

edited

Loading

image

Changes:

updated the default queries to add the description search to be available by default (as if a permanent search bar)
reduced the columns in the default view (also nicer for mobile, ignore the image here, I do not have all columns available locally)
reduced general use of margin
the paging option at the top of the table is now hidden
the options for grouping, showing the description under each desult, changing the page side is hidden for guests - this is to make the page less noisy on first visit

No worries if it's not the right way to go with it, just thought I would have a play 👍 got me set up with the project

Also added mobile support
image

@sarahboyce sarahboyce force-pushed the update-query-ui branch from dab1f86 to 6453451 Compare

June 25, 2023 20:44

@sarahboyce sarahboyce changed the title ~~(削除) Updated track query styling to be more compact. (削除ここまで)~~ (追記) Updated Trac query styling to be more compact and support mobile. (追記ここまで)

Jun 25, 2023

@sarahboyce sarahboyce force-pushed the update-query-ui branch from 6453451 to a545bca Compare

June 25, 2023 20:47

sarahboyce added 2 commits

January 25, 2024 20:42

@sarahboyce


 Updated Trac query styling to be more compact.

7d7f39e

@sarahboyce


 Added mobile support for Trac.

618c394

@sarahboyce sarahboyce force-pushed the update-query-ui branch from a545bca to 618c394 Compare

January 25, 2024 19:42

@sarahboyce sarahboyce mentioned this pull request

Jan 25, 2024

[styling] Too much whitespace between mainnav and content #152

Closed

@keikoro

Copy link

keikoro commented Sep 20, 2024

I've been looking for a way to add the description search field by default, would be great to at least have that added.

@keikoro keikoro mentioned this pull request

Sep 20, 2024

Missing option to save custom queries #209

Open

@carltongibson

Copy link

Member

carltongibson commented Oct 4, 2024

Oooh... this looks fun @sarahboyce 🤩

I could particularly do with this for the Timeline view

matthiask

matthiask reviewed

Oct 4, 2024

View reviewed changes

Copy link

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a clear improvement over the status quo.

@sarahboyce sarahboyce added the styling label

Oct 5, 2024

@sarahboyce sarahboyce requested a review from bmispelon

October 5, 2024 08:17

bmispelon

bmispelon requested changes

Oct 7, 2024

View reviewed changes

Copy link

Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thanks for picking it up! 🚀

I think there's a few easy wins that we could already merge, but the CSS changes would require a more thorough review (we need to consider other pages that use the stylesheet, not just the ticket list).

Do you have the bandwidth to split things out into separate commits, or would you prefer if I did it?

scss/trachacks.scss

}

#ctxtnav {

display: none;

Copy link

Member

@bmispelon bmispelon Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the effect of this change? From my (limited) testing, the ctctnav element is not present on the ticket list (I've seen it only on wiki pages)

trac-env/conf/trac.ini Show resolved Hide resolved

trac-env/templates/django_theme.html

</div>

# if req.authname == 'anonymous' or req.authname == '':

Copy link

Member

@bmispelon bmispelon Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use if not req.is_authenticated I think

trac-env/templates/django_theme.html

# if req.authname == 'anonymous' or req.authname == '':

Copy link

Member

@bmispelon bmispelon Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the advantage of using this empty element rather than for example a class on the <body>?

trac-env/templates/site_head.html Show resolved Hide resolved

@bmispelon bmispelon mentioned this pull request

Oct 8, 2024

Added mobile support for Trac. #212

Closed

Labels

styling

5 participants

@sarahboyce @keikoro @carltongibson @matthiask @bmispelon

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updated Trac query styling to be more compact and support mobile. #142

Are you sure you want to change the base?

Updated Trac query styling to be more compact and support mobile. #142

Uh oh!

Conversation

@sarahboyce sarahboyce commented Jun 24, 2023 •

edited

Loading

Uh oh!

Uh oh!

keikoro commented Sep 20, 2024

Uh oh!

carltongibson commented Oct 4, 2024

Uh oh!

@matthiask matthiask left a comment

Choose a reason for hiding this comment

Uh oh!

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

Uh oh!

@bmispelon bmispelon Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@bmispelon bmispelon Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

@bmispelon bmispelon Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Updated Trac query styling to be more compact and support mobile. #142

Are you sure you want to change the base?

Updated Trac query styling to be more compact and support mobile. #142

Uh oh!

Conversation

@sarahboyce sarahboyce commented Jun 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keikoro commented Sep 20, 2024

Uh oh!

carltongibson commented Oct 4, 2024

Uh oh!

@matthiask matthiask left a comment

Choose a reason for hiding this comment

Uh oh!

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

Uh oh!

@bmispelon bmispelon Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@bmispelon bmispelon Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

@bmispelon bmispelon Oct 7, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

@sarahboyce sarahboyce commented Jun 24, 2023 •

edited

Loading