-
Notifications
You must be signed in to change notification settings - Fork 299
Verified in all fields whether reserved field names are used #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #992 +/- ## ======================================= Coverage 96.84% 96.84% ======================================= Files 65 65 Lines 3929 3929 ======================================= Hits 3805 3805 Misses 124 124
Continue to review full report at Codecov.
|
auvipy
auvipy
approved these changes
Oct 7, 2021
In meta class only specifically declared fields in serializer are accessible. In case of `ModelSerializer` fields may be just on the model or if a user has overwritten what fields are being returned during runtime DJA won't notice. So there does not seem to be another way then simply hooking into the `get_fields` method to check for reserved field names.
@sliverc
sliverc
force-pushed
the
invalid_type_name
branch
from
October 7, 2021 18:02
e6545c8 to
5e3169b
Compare
n2ygk
n2ygk
approved these changes
Oct 8, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Follow up of #987
Description of the Change
In meta class only specifically declared fields in serializer are accessible. In case of
ModelSerializerfields may be just on the model or a user has overwritten what fields are being returned during runtime and DJA won't notice. So there does not seem to be another way then simply hooking into theget_fieldsmethod to check for reserved field names.Not ideal but still better to have a proper exception message during runtime then as it was before where a cryptic exception was raised.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS