Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Changed all external links to https #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Contributor

@SwarajBaral SwarajBaral commented Oct 4, 2021
edited by sliverc
Loading

Fixes #984

Description of the Change

Changed all external links from http:// to https://.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Copy link

codecov bot commented Oct 5, 2021
edited
Loading

Codecov Report

Merging #989 (83d56da) into master (4f596d7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #989 +/- ##
=======================================
 Coverage 96.82% 96.82% 
=======================================
 Files 65 65 
 Lines 3906 3906 
=======================================
 Hits 3782 3782 
 Misses 124 124 
Impacted Files Coverage Δ
rest_framework_json_api/django_filters/backends.py 100.00% <ø> (ø)
rest_framework_json_api/filters.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f596d7...83d56da. Read the comment docs.

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. See inline comments. Mainly though should the links localhost and 127.0.0.1 remain with http as those are internal and the runserver does not provide https.

Copy link
Contributor Author

@sliverc Fixed the remaining issues, kindly check.

@sliverc sliverc self-requested a review October 5, 2021 19:47
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@sliverc sliverc merged commit 414547a into django-json-api:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliverc sliverc sliverc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure that all external links are https

AltStyle によって変換されたページ (->オリジナル) /